Skip to content

Commit 4d444d8

Browse files
committed
refactor: remove unnecessary event bubbling
1 parent 909fb70 commit 4d444d8

3 files changed

Lines changed: 4 additions & 13 deletions

File tree

‎packages/dashboard/src/vaadin-dashboard-helpers.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ export function fireMove(element, delta) {
4444
element.dispatchEvent(
4545
new CustomEvent('item-move', {
4646
bubbles: true,
47-
composed: true,
4847
detail: { delta },
4948
}),
5049
);
@@ -61,7 +60,6 @@ export function fireResize(element, colspanDelta, rowspanDelta) {
6160
element.dispatchEvent(
6261
new CustomEvent('item-resize', {
6362
bubbles: true,
64-
composed: true,
6563
detail: {
6664
colspanDelta,
6765
rowspanDelta,
@@ -76,5 +74,5 @@ export function fireResize(element, colspanDelta, rowspanDelta) {
7674
* @param {HTMLElement} element
7775
*/
7876
export function fireRemove(element) {
79-
element.dispatchEvent(new CustomEvent('item-remove', { bubbles: true, composed: true }));
77+
element.dispatchEvent(new CustomEvent('item-remove', { bubbles: true }));
8078
}

‎packages/dashboard/src/vaadin-dashboard-item-mixin.js‎

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -229,9 +229,7 @@ export const DashboardItemMixin = (superClass) =>
229229

230230
/** @private */
231231
__selectedChanged(selected) {
232-
this.dispatchEvent(
233-
new CustomEvent('item-selected-changed', { bubbles: true, composed: true, detail: { value: selected } }),
234-
);
232+
this.dispatchEvent(new CustomEvent('item-selected-changed', { bubbles: true, detail: { value: selected } }));
235233
if (selected) {
236234
this.__focusTrapController.trapFocus(this.$.focustrap);
237235
} else {
@@ -291,15 +289,11 @@ export const DashboardItemMixin = (superClass) =>
291289

292290
/** @private */
293291
__moveModeChanged(moveMode) {
294-
this.dispatchEvent(
295-
new CustomEvent('item-move-mode-changed', { bubbles: true, composed: true, detail: { value: moveMode } }),
296-
);
292+
this.dispatchEvent(new CustomEvent('item-move-mode-changed', { bubbles: true, detail: { value: moveMode } }));
297293
}
298294

299295
/** @private */
300296
__resizeModeChanged(resizeMode) {
301-
this.dispatchEvent(
302-
new CustomEvent('item-resize-mode-changed', { bubbles: true, composed: true, detail: { value: resizeMode } }),
303-
);
297+
this.dispatchEvent(new CustomEvent('item-resize-mode-changed', { bubbles: true, detail: { value: resizeMode } }));
304298
}
305299
};

‎packages/dashboard/src/vaadin-dashboard.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,6 @@ class Dashboard extends ControllerMixin(DashboardLayoutMixin(ElementMixin(Themab
330330
__dispatchCustomEvent(eventName, item, value) {
331331
this.dispatchEvent(
332332
new CustomEvent(eventName, {
333-
bubbles: true,
334333
detail: {
335334
item,
336335
value,

0 commit comments

Comments
 (0)