Skip to content

Commit 54f903f

Browse files
authored
fix: add autocomplete="username" to user name field (#5036)
1 parent bd91cc3 commit 54f903f

3 files changed

Lines changed: 11 additions & 0 deletions

File tree

‎packages/login/src/vaadin-login-form.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ class LoginForm extends LoginMixin(ElementMixin(ThemableMixin(PolymerElement)))
7171
autocapitalize="none"
7272
autocorrect="off"
7373
spellcheck="false"
74+
autocomplete="username"
7475
>
7576
<input type="text" slot="input" on-keyup="_handleInputKeyup" />
7677
</vaadin-text-field>

‎packages/login/test/dom/__snapshots__/login-form.test.snap.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ snapshots["vaadin-login-form host default"] =
1414
>
1515
<vaadin-text-field
1616
autocapitalize="none"
17+
autocomplete="username"
1718
autocorrect="off"
1819
focused=""
1920
has-label=""
@@ -24,6 +25,7 @@ snapshots["vaadin-login-form host default"] =
2425
>
2526
<input
2627
aria-labelledby="label-vaadin-text-field-0"
28+
autocomplete="username"
2729
autocorrect="off"
2830
id="input-vaadin-text-field-6"
2931
name="username"
@@ -119,6 +121,7 @@ snapshots["vaadin-login-form host i18n"] =
119121
>
120122
<vaadin-text-field
121123
autocapitalize="none"
124+
autocomplete="username"
122125
autocorrect="off"
123126
focused=""
124127
has-label=""
@@ -129,6 +132,7 @@ snapshots["vaadin-login-form host i18n"] =
129132
>
130133
<input
131134
aria-labelledby="label-vaadin-text-field-0"
135+
autocomplete="username"
132136
autocorrect="off"
133137
id="input-vaadin-text-field-6"
134138
name="username"
@@ -224,6 +228,7 @@ snapshots["vaadin-login-form host noForgotPassword"] =
224228
>
225229
<vaadin-text-field
226230
autocapitalize="none"
231+
autocomplete="username"
227232
autocorrect="off"
228233
focused=""
229234
has-label=""
@@ -234,6 +239,7 @@ snapshots["vaadin-login-form host noForgotPassword"] =
234239
>
235240
<input
236241
aria-labelledby="label-vaadin-text-field-0"
242+
autocomplete="username"
237243
autocorrect="off"
238244
id="input-vaadin-text-field-6"
239245
name="username"

‎packages/login/test/dom/__snapshots__/login-overlay.test.snap.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ snapshots["vaadin-login-overlay host default"] =
2323
>
2424
<vaadin-text-field
2525
autocapitalize="none"
26+
autocomplete="username"
2627
autocorrect="off"
2728
focused=""
2829
has-label=""
@@ -33,6 +34,7 @@ snapshots["vaadin-login-overlay host default"] =
3334
>
3435
<input
3536
aria-labelledby="label-vaadin-text-field-0"
37+
autocomplete="username"
3638
autocorrect="off"
3739
id="input-vaadin-text-field-6"
3840
name="username"
@@ -138,6 +140,7 @@ snapshots["vaadin-login-overlay host i18n"] =
138140
>
139141
<vaadin-text-field
140142
autocapitalize="none"
143+
autocomplete="username"
141144
autocorrect="off"
142145
focused=""
143146
has-label=""
@@ -148,6 +151,7 @@ snapshots["vaadin-login-overlay host i18n"] =
148151
>
149152
<input
150153
aria-labelledby="label-vaadin-text-field-0"
154+
autocomplete="username"
151155
autocorrect="off"
152156
id="input-vaadin-text-field-6"
153157
name="username"

0 commit comments

Comments
 (0)