Skip to content

Commit 63348c9

Browse files
authored
test: extract validation tests, improve test coverage (#4093)
1 parent a1c399c commit 63348c9

2 files changed

Lines changed: 311 additions & 254 deletions

File tree

‎packages/number-field/test/number-field.test.js‎

Lines changed: 0 additions & 254 deletions
Original file line numberDiff line numberDiff line change
@@ -643,260 +643,6 @@ describe('number-field', () => {
643643
});
644644
});
645645
});
646-
647-
describe('input validation', () => {
648-
it('should be valid with numeric values', () => {
649-
expect(numberField.validate()).to.be.true;
650-
651-
numberField.value = '1';
652-
expect(input.value).to.be.equal('1');
653-
expect(numberField.validate()).to.be.true;
654-
});
655-
656-
it('should prevent setting non-numeric values', () => {
657-
numberField.value = 'foo';
658-
expect(numberField.value).to.be.empty;
659-
expect(numberField.validate()).to.be.true;
660-
});
661-
662-
it('should align checkValidity with the native input element', () => {
663-
numberField.value = -1;
664-
numberField.min = 0;
665-
666-
expect(numberField.checkValidity()).to.equal(input.checkValidity());
667-
});
668-
669-
it('should not validate when explicitly set to invalid', () => {
670-
numberField.invalid = true;
671-
672-
expect(numberField.value).to.be.empty;
673-
expect(numberField.validate()).to.be.false;
674-
675-
expect(numberField.invalid).to.be.true;
676-
});
677-
678-
it('should allow setting decimals', () => {
679-
numberField.value = 7.6;
680-
expect(numberField.value).to.be.equal('7.6');
681-
});
682-
683-
it('should not prevent invalid values applied programmatically (step)', () => {
684-
numberField.step = 0.1;
685-
numberField.value = 7.686;
686-
expect(numberField.value).to.be.equal('7.686');
687-
});
688-
689-
it('should not prevent invalid values applied programmatically (min)', () => {
690-
numberField.min = 2;
691-
numberField.value = 1;
692-
expect(numberField.value).to.be.equal('1');
693-
});
694-
695-
it('should not prevent invalid values applied programmatically (max)', () => {
696-
numberField.max = 2;
697-
numberField.value = 3;
698-
expect(numberField.value).to.be.equal('3');
699-
});
700-
701-
it('should validate when setting limits', () => {
702-
numberField.min = 2;
703-
numberField.max = 4;
704-
705-
numberField.value = '';
706-
expect(numberField.validate(), 'empty value is allowed because not required').to.be.true;
707-
708-
numberField.value = '3';
709-
expect(numberField.validate(), 'valid value should be in the range').to.be.true;
710-
711-
numberField.value = '1';
712-
expect(numberField.validate(), 'value should not be below min').to.be.false;
713-
714-
numberField.value = '3';
715-
expect(numberField.validate(), 'invalid status should be reset when setting valid value').to.be.true;
716-
717-
numberField.value = '5';
718-
expect(numberField.validate(), 'value should not be greater than max').to.be.false;
719-
});
720-
721-
it('should dispatch change event after validation', () => {
722-
const validateSpy = sinon.spy(numberField, 'validate');
723-
const changeSpy = sinon.spy();
724-
numberField.required = true;
725-
numberField.addEventListener('change', changeSpy);
726-
numberField.value = '123';
727-
input.dispatchEvent(new CustomEvent('change'));
728-
expect(validateSpy.calledOnce).to.be.true;
729-
expect(changeSpy.calledAfter(validateSpy)).to.be.true;
730-
});
731-
732-
describe('step values', () => {
733-
beforeEach(() => {
734-
numberField.step = 1.5;
735-
});
736-
737-
[-6, -1.5, 0, 1.5, 4.5].forEach((validValue) => {
738-
it(`should validate valid value "${validValue}" by step when defined by user`, () => {
739-
numberField.value = validValue;
740-
expect(numberField.validate()).to.be.true;
741-
});
742-
});
743-
744-
[-3.5, -1, 2, 2.5].forEach((invalidValue) => {
745-
it(`should validate invalid value "${invalidValue}" by step when defined by user`, () => {
746-
numberField.value = invalidValue;
747-
expect(numberField.validate()).to.be.false;
748-
});
749-
});
750-
});
751-
752-
describe('step basis', () => {
753-
beforeEach(() => {
754-
numberField.min = 1;
755-
numberField.step = 1.5;
756-
});
757-
758-
[1, 2.5, 4, 5.5].forEach((validValue) => {
759-
it(`should validate valid value "${validValue}" using min as basis`, () => {
760-
numberField.value = validValue;
761-
expect(numberField.validate()).to.be.true;
762-
});
763-
});
764-
765-
[1.5, 3, 5].forEach((invalidValue) => {
766-
it(`should validate invalid value "${invalidValue}" using min as basis`, () => {
767-
numberField.value = invalidValue;
768-
expect(numberField.validate()).to.be.false;
769-
});
770-
});
771-
});
772-
773-
it('should not validate by step when only min and max are set', () => {
774-
numberField.min = 1;
775-
numberField.max = 5;
776-
numberField.value = 1.5; // Would be invalid by default step=1
777-
expect(numberField.validate()).to.be.true;
778-
});
779-
780-
describe('removing validation constraints', () => {
781-
it('should update "invalid" state when "min" is removed', () => {
782-
numberField.value = '42';
783-
numberField.min = 50;
784-
numberField.validate();
785-
expect(numberField.invalid).to.be.true;
786-
787-
numberField.min = '';
788-
expect(numberField.invalid).to.be.false;
789-
});
790-
791-
it('should update "invalid" state when "max" is removed', () => {
792-
numberField.value = '42';
793-
numberField.max = 20;
794-
numberField.validate();
795-
expect(numberField.invalid).to.be.true;
796-
797-
numberField.max = '';
798-
expect(numberField.invalid).to.be.false;
799-
});
800-
801-
it('should update "invalid" state when "step" is removed', () => {
802-
numberField.value = '3';
803-
numberField.min = 0;
804-
numberField.step = 2;
805-
numberField.validate();
806-
expect(numberField.invalid).to.be.true;
807-
808-
numberField.step = '';
809-
expect(numberField.invalid).to.be.false;
810-
});
811-
812-
it('should not set "invalid" to false when "min" is set to 0', () => {
813-
numberField.value = '-5';
814-
numberField.min = -1;
815-
numberField.validate();
816-
expect(numberField.invalid).to.be.true;
817-
818-
numberField.min = 0;
819-
expect(numberField.invalid).to.be.true;
820-
});
821-
822-
it('should not set "invalid" to false when "max" is set to 0', () => {
823-
numberField.value = '5';
824-
numberField.max = 1;
825-
numberField.validate();
826-
expect(numberField.invalid).to.be.true;
827-
828-
numberField.max = 0;
829-
expect(numberField.invalid).to.be.true;
830-
});
831-
});
832-
});
833-
});
834-
835-
describe('step attribute', () => {
836-
let numberField;
837-
838-
beforeEach(() => {
839-
numberField = fixtureSync('<vaadin-number-field step="1.5"></vaadin-number-field>');
840-
});
841-
842-
it('should validate by step when defined as attribute', () => {
843-
numberField.value = 1;
844-
expect(numberField.validate()).to.be.false;
845-
numberField.value = 1.5;
846-
expect(numberField.validate()).to.be.true;
847-
});
848-
});
849-
850-
describe('default step attribute', () => {
851-
let numberField;
852-
853-
beforeEach(() => {
854-
numberField = fixtureSync('<vaadin-number-field step="1"></vaadin-number-field>');
855-
});
856-
857-
it('should validate by step when default value defined as attribute', () => {
858-
numberField.value = 1.5;
859-
expect(numberField.validate()).to.be.false;
860-
numberField.value = 1;
861-
expect(numberField.validate()).to.be.true;
862-
});
863-
});
864-
865-
describe('checkValidity', () => {
866-
it('should return true when called before connected to the DOM', () => {
867-
const numberField = document.createElement('vaadin-number-field');
868-
expect(numberField.checkValidity()).to.be.true;
869-
});
870-
871-
it('should return false when called before connected to the DOM and invalid', () => {
872-
const numberField = document.createElement('vaadin-number-field');
873-
numberField.invalid = true;
874-
expect(numberField.checkValidity()).to.be.false;
875-
});
876-
});
877-
878-
describe('invalid', () => {
879-
let numberField;
880-
881-
beforeEach(() => {
882-
numberField = fixtureSync('<vaadin-number-field invalid></vaadin-number-field>');
883-
});
884-
885-
it('should not remove "invalid" state when ready', () => {
886-
expect(numberField.invalid).to.be.true;
887-
});
888-
});
889-
890-
describe('invalid with value', () => {
891-
let numberField;
892-
893-
beforeEach(() => {
894-
numberField = fixtureSync('<vaadin-number-field invalid value="123456"></vaadin-number-field>');
895-
});
896-
897-
it('should not remove "invalid" state when ready', () => {
898-
expect(numberField.invalid).to.be.true;
899-
});
900646
});
901647

902648
describe('required', () => {

0 commit comments

Comments
 (0)