Skip to content

Commit 9029f98

Browse files
authored
fix: avoid having selectAll default value clear pre-selections (#2085)
1 parent 39ab1c1 commit 9029f98

2 files changed

Lines changed: 16 additions & 0 deletions

File tree

‎packages/vaadin-grid/src/vaadin-grid-selection-column.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,12 @@ class GridSelectionColumnElement extends GridColumnElement {
174174
return;
175175
}
176176

177+
if (!this.__selectAllInitialized) {
178+
// The initial value for selectAll property was applied, avoid clearing pre-selected items
179+
this.__selectAllInitialized = true;
180+
return;
181+
}
182+
177183
if (this._selectAllChangeLock) {
178184
return;
179185
}

‎packages/vaadin-grid/test/selection.test.js‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,16 @@ describe('multi selection column', () => {
392392
expect(selectionColumn.selectAll).to.be.false;
393393
});
394394

395+
it('should not clear pre-selected items', () => {
396+
const grid = fixtureSync(`
397+
<vaadin-grid selected-items='[{"value": "foo"}]'>
398+
<vaadin-grid-selection-column></vaadin-grid-selection-column>
399+
<vaadin-grid-column path="value"></vaadin-grid-column>
400+
</vaadin-grid>
401+
`);
402+
expect(grid.selectedItems).to.have.length(1);
403+
});
404+
395405
it('should have selectAll after selecting all manually', () => {
396406
selectAllCheckbox.click();
397407
firstBodyCheckbox.checked = true;

0 commit comments

Comments
 (0)