Skip to content

Commit 9548842

Browse files
authored
refactor: use div with heading role instead of h2 in form title (#8441)
1 parent 2cd6a16 commit 9548842

6 files changed

Lines changed: 29 additions & 9 deletions

File tree

‎packages/login/src/vaadin-lit-login-form-wrapper.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class LoginFormWrapper extends ThemableMixin(PolylitMixin(LitElement)) {
5151
render() {
5252
return html`
5353
<section part="form">
54-
<h2 part="form-title">${this.i18n.form.title}</h2>
54+
<div part="form-title" role="heading" aria-level="2">${this.i18n.form.title}</div>
5555
<div part="error-message" ?hidden="${!this.error}">
5656
<strong part="error-message-title">${this.i18n.errorMessage.title}</strong>
5757
<p part="error-message-description">${this.i18n.errorMessage.message}</p>

‎packages/login/src/vaadin-login-form-wrapper.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class LoginFormWrapper extends ThemableMixin(PolymerElement) {
2323
static get template() {
2424
return html`
2525
<section part="form">
26-
<h2 part="form-title">[[i18n.form.title]]</h2>
26+
<div part="form-title" part="form-title" role="heading" aria-level="2">[[i18n.form.title]]</div>
2727
<div part="error-message" hidden$="[[!error]]">
2828
<strong part="error-message-title">[[i18n.errorMessage.title]]</strong>
2929
<p part="error-message-description">[[i18n.errorMessage.message]]</p>

‎packages/login/test/dom/__snapshots__/login-form.test.snap.js‎

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -573,9 +573,13 @@ snapshots["vaadin-login-form host noForgotPassword"] =
573573

574574
snapshots["vaadin-login-form shadow default"] =
575575
`<section part="form">
576-
<h2 part="form-title">
576+
<div
577+
aria-level="2"
578+
part="form-title"
579+
role="heading"
580+
>
577581
Log in
578-
</h2>
582+
</div>
579583
<div
580584
hidden=""
581585
part="error-message"
@@ -607,9 +611,13 @@ snapshots["vaadin-login-form shadow default"] =
607611

608612
snapshots["vaadin-login-form shadow error"] =
609613
`<section part="form">
610-
<h2 part="form-title">
614+
<div
615+
aria-level="2"
616+
part="form-title"
617+
role="heading"
618+
>
611619
Log in
612-
</h2>
620+
</div>
613621
<div part="error-message">
614622
<strong part="error-message-title">
615623
Incorrect username or password
@@ -638,9 +646,13 @@ snapshots["vaadin-login-form shadow error"] =
638646

639647
snapshots["vaadin-login-form shadow i18n"] =
640648
`<section part="form">
641-
<h2 part="form-title">
649+
<div
650+
aria-level="2"
651+
part="form-title"
652+
role="heading"
653+
>
642654
Kirjaudu sisään
643-
</h2>
655+
</div>
644656
<div
645657
hidden=""
646658
part="error-message"

‎packages/login/theme/lumo/vaadin-login-form-wrapper-styles.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ const loginFormWrapper = css`
1515
1616
[part='form-title'] {
1717
margin-top: calc(var(--lumo-font-size-xxxl) - var(--lumo-font-size-xxl));
18+
color: var(--lumo-header-text-color);
19+
font-size: var(--lumo-font-size-xxl);
20+
font-weight: 600;
21+
line-height: var(--lumo-line-height-xs);
1822
}
1923
2024
::slotted([slot='submit']) {

‎packages/login/theme/material/vaadin-login-form-wrapper-styles.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ const loginFormWrapper = css`
1919
[part='form-title'] {
2020
margin-top: calc(var(--material-h3-font-size) - var(--material-h4-font-size));
2121
font-size: var(--material-h5-font-size);
22+
font-weight: 300;
23+
line-height: 1.1;
24+
letter-spacing: -0.01em;
25+
text-indent: -0.07em;
2226
}
2327
2428
::slotted([slot='submit']) {

‎packages/login/theme/material/vaadin-login-overlay-styles.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ const loginFormWrapper = css`
311311
padding: 2rem 2.5rem 2rem 1.8rem;
312312
}
313313
314-
:host([theme~='with-overlay']) [part='form'] h2 {
314+
:host([theme~='with-overlay']) [part='form-title'] {
315315
text-align: center;
316316
font-size: 1.8em;
317317
font-weight: 500;

0 commit comments

Comments
 (0)