Skip to content

Commit a126902

Browse files
authored
chore: fix inconsistent default property values in guidelines (#12023)
1 parent 39f9346 commit a126902

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

‎guidelines/01-repository.md‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77
[TypeScript](07-typescript.md)).
88

99
Every component is built as a Lit `LitElement`, layered with the Vaadin
10-
mixins documented in [Common packages](05-common-packages.md). New components
11-
use Lit-native features (`static properties`, `firstUpdated`, `updated`,
12-
field initializers) rather than Polymer-style options.
10+
mixins documented in [Common packages](05-common-packages.md).
1311

1412
## Test stack
1513

‎guidelines/13-checklist.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ not a substitute for reading [Component Structure](03-component-structure.md) an
3030
- [ ] `static get styles()` returns the imported base styles.
3131
- [ ] `static get properties()` declares every reactive property with a
3232
JSDoc comment (and `@attr` for camelCase ones).
33-
- [ ] Defaults set via field initializers, not a `value:` property option.
33+
- [ ] Defaults set via `value:` property option.
3434
- [ ] `ready()` sets host attributes (e.g. `role`) and attaches controllers.
3535
- [ ] `updated(changed)` reacts to property changes (no Polymer observers).
3636
- [ ] `defineCustomElement(...)` called at the bottom of the source file.

0 commit comments

Comments
 (0)