Skip to content

Commit a407e3e

Browse files
authored
fix: add aria-hidden to clear and toggle buttons (#3375)
1 parent 29f09eb commit a407e3e

14 files changed

Lines changed: 47 additions & 10 deletions

File tree

‎packages/combo-box/src/vaadin-combo-box.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,8 @@ class ComboBox extends ComboBoxDataProviderMixin(
183183
>
184184
<slot name="prefix" slot="prefix"></slot>
185185
<slot name="input"></slot>
186-
<div id="clearButton" part="clear-button" slot="suffix"></div>
187-
<div id="toggleButton" part="toggle-button" slot="suffix"></div>
186+
<div id="clearButton" part="clear-button" slot="suffix" aria-hidden="true"></div>
187+
<div id="toggleButton" part="toggle-button" slot="suffix" aria-hidden="true"></div>
188188
</vaadin-input-container>
189189
190190
<div part="helper-text">

‎packages/date-picker/src/vaadin-date-picker.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,8 @@ class DatePicker extends DatePickerMixin(InputControlMixin(ThemableMixin(Element
144144
>
145145
<slot name="prefix" slot="prefix"></slot>
146146
<slot name="input"></slot>
147-
<div id="clearButton" part="clear-button" slot="suffix"></div>
148-
<div part="toggle-button" slot="suffix" role="button"></div>
147+
<div id="clearButton" part="clear-button" slot="suffix" aria-hidden="true"></div>
148+
<div part="toggle-button" slot="suffix" role="button" aria-hidden="true"></div>
149149
</vaadin-input-container>
150150
151151
<div part="helper-text">

‎packages/email-field/test/dom/__snapshots__/email-field.test.snap.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ snapshots["vaadin-email-field shadow default"] =
2626
>
2727
</slot>
2828
<div
29+
aria-hidden="true"
2930
id="clearButton"
3031
part="clear-button"
3132
slot="suffix"
@@ -72,6 +73,7 @@ snapshots["vaadin-email-field shadow disabled"] =
7273
>
7374
</slot>
7475
<div
76+
aria-hidden="true"
7577
id="clearButton"
7678
part="clear-button"
7779
slot="suffix"
@@ -118,6 +120,7 @@ snapshots["vaadin-email-field shadow readonly"] =
118120
>
119121
</slot>
120122
<div
123+
aria-hidden="true"
121124
id="clearButton"
122125
part="clear-button"
123126
slot="suffix"
@@ -164,6 +167,7 @@ snapshots["vaadin-email-field shadow invalid"] =
164167
>
165168
</slot>
166169
<div
170+
aria-hidden="true"
167171
id="clearButton"
168172
part="clear-button"
169173
slot="suffix"
@@ -210,6 +214,7 @@ snapshots["vaadin-email-field shadow theme"] =
210214
>
211215
</slot>
212216
<div
217+
aria-hidden="true"
213218
id="clearButton"
214219
part="clear-button"
215220
slot="suffix"

‎packages/integer-field/test/dom/__snapshots__/integer-field.test.snap.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ snapshots["vaadin-integer-field shadow default"] =
3232
>
3333
</slot>
3434
<div
35+
aria-hidden="true"
3536
id="clearButton"
3637
part="clear-button"
3738
slot="suffix"
@@ -86,6 +87,7 @@ snapshots["vaadin-integer-field shadow controls"] =
8687
>
8788
</slot>
8889
<div
90+
aria-hidden="true"
8991
id="clearButton"
9092
part="clear-button"
9193
slot="suffix"
@@ -143,6 +145,7 @@ snapshots["vaadin-integer-field shadow disabled"] =
143145
>
144146
</slot>
145147
<div
148+
aria-hidden="true"
146149
id="clearButton"
147150
part="clear-button"
148151
slot="suffix"
@@ -201,6 +204,7 @@ snapshots["vaadin-integer-field shadow readonly"] =
201204
>
202205
</slot>
203206
<div
207+
aria-hidden="true"
204208
id="clearButton"
205209
part="clear-button"
206210
slot="suffix"
@@ -259,6 +263,7 @@ snapshots["vaadin-integer-field shadow invalid"] =
259263
>
260264
</slot>
261265
<div
266+
aria-hidden="true"
262267
id="clearButton"
263268
part="clear-button"
264269
slot="suffix"
@@ -317,6 +322,7 @@ snapshots["vaadin-integer-field shadow theme"] =
317322
>
318323
</slot>
319324
<div
325+
aria-hidden="true"
320326
id="clearButton"
321327
part="clear-button"
322328
slot="suffix"

‎packages/number-field/src/vaadin-number-field.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ export class NumberField extends InputFieldMixin(SlotStylesMixin(ThemableMixin(E
105105
<slot name="prefix" slot="prefix"></slot>
106106
<slot name="input"></slot>
107107
<slot name="suffix" slot="suffix"></slot>
108-
<div id="clearButton" part="clear-button" slot="suffix"></div>
108+
<div id="clearButton" part="clear-button" slot="suffix" aria-hidden="true"></div>
109109
<div
110110
disabled$="[[!_allowed(1, value, min, max, step)]]"
111111
part="increase-button"

‎packages/number-field/test/dom/__snapshots__/number-field.test.snap.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ snapshots["vaadin-number-field shadow default"] =
3232
>
3333
</slot>
3434
<div
35+
aria-hidden="true"
3536
id="clearButton"
3637
part="clear-button"
3738
slot="suffix"
@@ -86,6 +87,7 @@ snapshots["vaadin-number-field shadow controls"] =
8687
>
8788
</slot>
8889
<div
90+
aria-hidden="true"
8991
id="clearButton"
9092
part="clear-button"
9193
slot="suffix"
@@ -143,6 +145,7 @@ snapshots["vaadin-number-field shadow disabled"] =
143145
>
144146
</slot>
145147
<div
148+
aria-hidden="true"
146149
id="clearButton"
147150
part="clear-button"
148151
slot="suffix"
@@ -201,6 +204,7 @@ snapshots["vaadin-number-field shadow readonly"] =
201204
>
202205
</slot>
203206
<div
207+
aria-hidden="true"
204208
id="clearButton"
205209
part="clear-button"
206210
slot="suffix"
@@ -259,6 +263,7 @@ snapshots["vaadin-number-field shadow invalid"] =
259263
>
260264
</slot>
261265
<div
266+
aria-hidden="true"
262267
id="clearButton"
263268
part="clear-button"
264269
slot="suffix"
@@ -317,6 +322,7 @@ snapshots["vaadin-number-field shadow theme"] =
317322
>
318323
</slot>
319324
<div
325+
aria-hidden="true"
320326
id="clearButton"
321327
part="clear-button"
322328
slot="suffix"

‎packages/password-field/test/dom/__snapshots__/password-field.test.snap.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ snapshots["vaadin-password-field shadow default"] =
2626
>
2727
</slot>
2828
<div
29+
aria-hidden="true"
2930
id="clearButton"
3031
part="clear-button"
3132
slot="suffix"
@@ -79,6 +80,7 @@ snapshots["vaadin-password-field shadow disabled"] =
7980
>
8081
</slot>
8182
<div
83+
aria-hidden="true"
8284
id="clearButton"
8385
part="clear-button"
8486
slot="suffix"
@@ -132,6 +134,7 @@ snapshots["vaadin-password-field shadow readonly"] =
132134
>
133135
</slot>
134136
<div
137+
aria-hidden="true"
135138
id="clearButton"
136139
part="clear-button"
137140
slot="suffix"
@@ -185,6 +188,7 @@ snapshots["vaadin-password-field shadow invalid"] =
185188
>
186189
</slot>
187190
<div
191+
aria-hidden="true"
188192
id="clearButton"
189193
part="clear-button"
190194
slot="suffix"
@@ -238,6 +242,7 @@ snapshots["vaadin-password-field shadow theme"] =
238242
>
239243
</slot>
240244
<div
245+
aria-hidden="true"
241246
id="clearButton"
242247
part="clear-button"
243248
slot="suffix"

‎packages/select/src/vaadin-select.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
162162
>
163163
<slot name="prefix" slot="prefix"></slot>
164164
<slot name="value"></slot>
165-
<div part="toggle-button" slot="suffix"></div>
165+
<div part="toggle-button" slot="suffix" aria-hidden="true"></div>
166166
</vaadin-input-container>
167167
168168
<div part="helper-text">

‎packages/select/test/dom/__snapshots__/select.test.snap.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ snapshots["vaadin-select shadow default"] =
2121
<slot name="value">
2222
</slot>
2323
<div
24+
aria-hidden="true"
2425
part="toggle-button"
2526
slot="suffix"
2627
>
@@ -65,6 +66,7 @@ snapshots["vaadin-select shadow disabled"] =
6566
<slot name="value">
6667
</slot>
6768
<div
69+
aria-hidden="true"
6870
part="toggle-button"
6971
slot="suffix"
7072
>
@@ -109,6 +111,7 @@ snapshots["vaadin-select shadow readonly"] =
109111
<slot name="value">
110112
</slot>
111113
<div
114+
aria-hidden="true"
112115
part="toggle-button"
113116
slot="suffix"
114117
>
@@ -153,6 +156,7 @@ snapshots["vaadin-select shadow invalid"] =
153156
<slot name="value">
154157
</slot>
155158
<div
159+
aria-hidden="true"
156160
part="toggle-button"
157161
slot="suffix"
158162
>
@@ -197,6 +201,7 @@ snapshots["vaadin-select shadow theme"] =
197201
<slot name="value">
198202
</slot>
199203
<div
204+
aria-hidden="true"
200205
part="toggle-button"
201206
slot="suffix"
202207
>

‎packages/text-area/src/vaadin-text-area.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ export class TextArea extends ResizeMixin(PatternMixin(InputFieldMixin(ThemableM
147147
<slot name="prefix" slot="prefix"></slot>
148148
<slot name="textarea"></slot>
149149
<slot name="suffix" slot="suffix"></slot>
150-
<div id="clearButton" part="clear-button" slot="suffix"></div>
150+
<div id="clearButton" part="clear-button" slot="suffix" aria-hidden="true"></div>
151151
</vaadin-input-container>
152152
153153
<div part="helper-text">

0 commit comments

Comments
 (0)