File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -101,6 +101,15 @@ class Select extends SelectBaseMixin(ElementMixin(ThemableMixin(PolylitMixin(Lit
101101 ` ;
102102 }
103103
104+ /** @protected */
105+ ready ( ) {
106+ super . ready ( ) ;
107+
108+ const overlay = this . shadowRoot . querySelector ( 'vaadin-select-overlay' ) ;
109+ overlay . owner = this ;
110+ this . _overlayElement = overlay ;
111+ }
112+
104113 /** @private */
105114 _onOpenedChanged ( event ) {
106115 this . opened = event . detail . value ;
Original file line number Diff line number Diff line change @@ -171,10 +171,6 @@ export const SelectBaseMixin = (superClass) =>
171171 ready ( ) {
172172 super . ready ( ) ;
173173
174- const overlay = this . shadowRoot . querySelector ( 'vaadin-select-overlay' ) ;
175- overlay . owner = this ;
176- this . _overlayElement = overlay ;
177-
178174 this . _inputContainer = this . shadowRoot . querySelector ( '[part~="input-field"]' ) ;
179175
180176 this . _valueButtonController = new ButtonController ( this ) ;
Original file line number Diff line number Diff line change @@ -55,6 +55,17 @@ export class SelectOverlay extends PositionMixin(OverlayMixin(DirMixin(ThemableM
5555 ` ;
5656 }
5757
58+ /** @protected */
59+ ready ( ) {
60+ super . ready ( ) ;
61+
62+ // When setting `opened` as an attribute, the overlay is already teleported to body
63+ // by the time when `ready()` callback of the `vaadin-select` is executed by Polymer,
64+ // so querySelector() would return null. So we use this workaround to set properties.
65+ this . owner = this . __dataHost ;
66+ this . owner . _overlayElement = this ;
67+ }
68+
5869 requestContentUpdate ( ) {
5970 super . requestContentUpdate ( ) ;
6071
Original file line number Diff line number Diff line change 1+ import { expect } from '@esm-bundle/chai' ;
2+ import { fixtureSync } from '@vaadin/testing-helpers' ;
3+ import '../vaadin-select.js' ;
4+
5+ // NOTE: this test is Polymer only as it checks for Polymer specific bug.
6+ // Do not import `not-animated-styles.js` in this test intentionally, as
7+ // otherwise the immediately closed overlay would make it false positive.
8+
9+ describe ( 'pre-opened' , ( ) => {
10+ it ( 'should not throw error when adding a pre-opened select' , ( ) => {
11+ expect ( ( ) => {
12+ fixtureSync ( '<vaadin-select opened></vaadin-select>' ) ;
13+ } ) . to . not . throw ( Error ) ;
14+ } ) ;
15+ } ) ;
You can’t perform that action at this time.
0 commit comments