Skip to content

Commit a988f88

Browse files
fix: make context menu renderer arguments required (#4918) (#4924)
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
1 parent a9b54ce commit a988f88

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

‎packages/context-menu/src/vaadin-context-menu.d.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ export interface ContextMenuRendererContext {
1616

1717
export type ContextMenuRenderer = (
1818
root: HTMLElement,
19-
contextMenu?: ContextMenu,
20-
context?: ContextMenuRendererContext,
19+
contextMenu: ContextMenu,
20+
context: ContextMenuRendererContext,
2121
) => void;
2222

2323
/**

‎packages/context-menu/test/typings/context-menu.types.ts‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
import '../../vaadin-context-menu.js';
22
import type {
3+
ContextMenu,
34
ContextMenuItem,
45
ContextMenuItemSelectedEvent,
56
ContextMenuOpenedChangedEvent,
7+
ContextMenuRenderer,
8+
ContextMenuRendererContext,
69
} from '../../vaadin-context-menu.js';
710

811
const menu = document.createElement('vaadin-context-menu');
@@ -18,3 +21,12 @@ menu.addEventListener('item-selected', (event) => {
1821
assertType<ContextMenuItemSelectedEvent>(event);
1922
assertType<ContextMenuItem>(event.detail.value);
2023
});
24+
25+
const renderer: ContextMenuRenderer = (root, contextMenu, context) => {
26+
assertType<HTMLElement>(root);
27+
assertType<ContextMenu>(contextMenu);
28+
assertType<ContextMenuRendererContext>(context);
29+
assertType<HTMLElement>(context.target);
30+
};
31+
32+
menu.renderer = renderer;

0 commit comments

Comments
 (0)