Skip to content

Commit b9ee4bf

Browse files
authored
fix: reset width on menu-bar buttons when restoring them (#9028)
1 parent 06b592b commit b9ee4bf

2 files changed

Lines changed: 17 additions & 0 deletions

File tree

‎packages/menu-bar/src/vaadin-menu-bar-mixin.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,7 @@ export const MenuBarMixin = (superClass) =>
452452
button.disabled = (button.item && button.item.disabled) || this.disabled;
453453
button.style.visibility = '';
454454
button.style.position = '';
455+
button.style.width = '';
455456

456457
// Teleport item component back from "overflow" sub-menu
457458
const item = button.item && button.item.component;

‎packages/menu-bar/test/overflow.test.js‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,22 @@ describe('overflow', () => {
149149
expect(overflow.hasAttribute('hidden')).to.be.false;
150150
});
151151

152+
it('should reset buttons after moving back from the overflow menu', async () => {
153+
menu.style.width = '400px';
154+
await nextResize(menu);
155+
156+
// Set theme to make button hidden
157+
menu.setAttribute('theme', 'big');
158+
await nextUpdate(menu);
159+
160+
// Reset width to make button visible
161+
menu.style.width = 'auto';
162+
await nextResize(menu);
163+
164+
assertVisible(buttons[3]);
165+
expect(buttons[3].offsetWidth).to.equal(100);
166+
});
167+
152168
it('should set tabindex on the last remaining button when width decreased', async () => {
153169
buttons[0].focus();
154170
arrowRight(buttons[0]);

0 commit comments

Comments
 (0)