Skip to content

Commit bc227bd

Browse files
bwajtrvursen
andauthored
fix: process all intersection observer event entries (#5668)
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
1 parent 319682e commit bc227bd

2 files changed

Lines changed: 26 additions & 2 deletions

File tree

‎packages/tooltip/src/vaadin-tooltip.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,8 +474,8 @@ class Tooltip extends OverlayClassMixin(ThemePropertyMixin(ElementMixin(PolymerE
474474
this.__onOverlayOpen = this.__onOverlayOpen.bind(this);
475475

476476
this.__targetVisibilityObserver = new IntersectionObserver(
477-
([entry]) => {
478-
this.__onTargetVisibilityChange(entry.isIntersecting);
477+
(entries) => {
478+
entries.forEach((entry) => this.__onTargetVisibilityChange(entry.isIntersecting));
479479
},
480480
{ threshold: 1 },
481481
);

‎packages/tooltip/test/tooltip.test.js‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -687,6 +687,30 @@ describe('vaadin-tooltip', () => {
687687
expect(overlay.opened).to.be.true;
688688
});
689689
});
690+
691+
describe('moving target', () => {
692+
let container, target;
693+
694+
beforeEach(async () => {
695+
container = fixtureSync(`
696+
<div>
697+
<div id="first">First</div>
698+
<div id="second">Second</div>
699+
</div>
700+
`);
701+
target = container.querySelector('#second');
702+
tooltip.target = target;
703+
await nextFrame();
704+
});
705+
706+
it('should still open overlay when target element was moved', async () => {
707+
const firstElement = container.querySelector('#first');
708+
firstElement.before(target);
709+
await waitForIntersectionObserver();
710+
mouseenter(target);
711+
expect(overlay.opened).to.be.true;
712+
});
713+
});
690714
});
691715

692716
describe('manual opened', () => {

0 commit comments

Comments
 (0)