Skip to content

Commit bced5a2

Browse files
authored
test: improve test coverage for value commit scenarios (#6416)
1 parent fe87024 commit bced5a2

4 files changed

Lines changed: 413 additions & 352 deletions

File tree

‎packages/time-picker/test/events.test.js‎

Lines changed: 1 addition & 140 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect } from '@esm-bundle/chai';
2-
import { arrowDown, arrowUp, enter, esc, fixtureSync } from '@vaadin/testing-helpers';
2+
import { fixtureSync } from '@vaadin/testing-helpers';
33
import { sendKeys } from '@web/test-runner-commands';
44
import sinon from 'sinon';
55
import './not-animated-styles.js';
@@ -8,145 +8,6 @@ import '../vaadin-time-picker.js';
88
describe('events', () => {
99
let timePicker;
1010

11-
describe('change event', () => {
12-
let changeSpy, inputElement;
13-
14-
beforeEach(() => {
15-
timePicker = fixtureSync(`<vaadin-time-picker></vaadin-time-picker>`);
16-
inputElement = timePicker.inputElement;
17-
changeSpy = sinon.spy();
18-
timePicker.addEventListener('change', changeSpy);
19-
});
20-
21-
it('should be fired when committing user input with Enter', async () => {
22-
inputElement.focus();
23-
await sendKeys({ type: '00:00' });
24-
await sendKeys({ press: 'Enter' });
25-
expect(changeSpy.calledOnce).to.be.true;
26-
});
27-
28-
it('should be fired when selecting a time with arrows and committing with Enter', () => {
29-
arrowDown(inputElement);
30-
arrowDown(inputElement);
31-
enter(inputElement);
32-
expect(changeSpy.calledOnce).to.be.true;
33-
});
34-
35-
it('should be fired on clear button click', () => {
36-
timePicker.clearButtonVisible = true;
37-
timePicker.value = '00:00';
38-
timePicker.$.clearButton.click();
39-
expect(changeSpy.calledOnce).to.be.true;
40-
});
41-
42-
it('should be fired on arrow keys when no dropdown opens', () => {
43-
timePicker.step = 1;
44-
arrowDown(inputElement);
45-
expect(changeSpy.calledOnce).to.be.true;
46-
arrowUp(inputElement);
47-
expect(changeSpy.calledTwice).to.be.true;
48-
});
49-
50-
it('should be fired after value-changed event on arrow keys', () => {
51-
timePicker.step = 0.5;
52-
const valueChangedSpy = sinon.spy();
53-
timePicker.addEventListener('value-changed', valueChangedSpy);
54-
arrowDown(inputElement);
55-
expect(valueChangedSpy.calledOnce).to.be.true;
56-
expect(changeSpy.calledOnce).to.be.true;
57-
expect(valueChangedSpy.calledBefore(changeSpy)).to.be.true;
58-
});
59-
60-
it('should not be fired on focused time change', async () => {
61-
inputElement.focus();
62-
await sendKeys({ type: '00:00' });
63-
expect(changeSpy.called).to.be.false;
64-
});
65-
66-
it('should not be fired on programmatic value change', () => {
67-
timePicker.value = '01:00';
68-
expect(changeSpy.called).to.be.false;
69-
});
70-
71-
it('should not be fired on programmatic value change after manual one', () => {
72-
timePicker.value = '00:00';
73-
timePicker.open();
74-
inputElement.value = '';
75-
arrowDown(inputElement);
76-
arrowDown(inputElement);
77-
enter(inputElement);
78-
expect(changeSpy.calledOnce).to.be.true;
79-
// Mimic native change happening on text-field blur
80-
document.body.click();
81-
timePicker.value = '02:00';
82-
expect(changeSpy.calledOnce).to.be.true;
83-
});
84-
85-
it('should not be fired on Enter if the value has not changed', () => {
86-
timePicker.value = '01:00';
87-
timePicker.open();
88-
enter(inputElement);
89-
expect(changeSpy.called).to.be.false;
90-
});
91-
92-
it('should not be fired on revert', () => {
93-
timePicker.open();
94-
timePicker.value = '01:00';
95-
esc(inputElement);
96-
esc(inputElement);
97-
expect(changeSpy.called).to.be.false;
98-
});
99-
100-
it('should be fired only once', async () => {
101-
timePicker.focus();
102-
timePicker.open();
103-
await sendKeys({ type: '0' });
104-
enter(inputElement);
105-
inputElement.blur();
106-
expect(changeSpy.callCount).to.equal(1);
107-
});
108-
109-
it('should not be fired again on Enter if the value has not changed', async () => {
110-
inputElement.focus();
111-
await sendKeys({ type: '10:00' });
112-
await sendKeys({ press: 'Enter' });
113-
expect(changeSpy).to.be.calledOnce;
114-
115-
await sendKeys({ press: 'Backspace' });
116-
await sendKeys({ press: 'Enter' });
117-
expect(changeSpy).to.be.calledOnce;
118-
});
119-
120-
it('should not be fired again on blur if the value has not changed', async () => {
121-
timePicker.step = 0.5;
122-
inputElement.focus();
123-
124-
await sendKeys({ press: 'ArrowDown' });
125-
expect(changeSpy).to.be.calledOnce;
126-
127-
inputElement.blur();
128-
expect(changeSpy).to.be.calledOnce;
129-
});
130-
131-
it('should not be fired on Enter after value set programmatically', async () => {
132-
timePicker.value = '10:00';
133-
inputElement.focus();
134-
135-
await sendKeys({ press: 'Backspace' });
136-
await sendKeys({ press: 'Enter' });
137-
expect(changeSpy.called).to.be.false;
138-
});
139-
140-
it('should be fired on Enter when trying to commit bad input and field has value', async () => {
141-
timePicker.value = '10:00';
142-
inputElement.focus();
143-
inputElement.select();
144-
await sendKeys({ type: 'foo' });
145-
await sendKeys({ press: 'Enter' });
146-
expect(changeSpy.calledOnce).to.be.true;
147-
});
148-
});
149-
15011
describe('has-input-value-changed event', () => {
15112
let clearButton, hasInputValueChangedSpy, valueChangedSpy;
15213

‎packages/time-picker/test/time-picker.test.js‎

Lines changed: 1 addition & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -37,27 +37,12 @@ describe('time-picker', () => {
3737
expect(timePicker.value).to.be.equal('');
3838
});
3939

40-
it('should not set value if the format is invalid', () => {
41-
setInputValue(timePicker, 'invalid');
42-
enter(inputElement);
43-
expect(timePicker.value).to.be.equal('');
44-
expect(inputElement.value).to.be.equal('invalid');
45-
});
46-
4740
it('should not allow setting invalid value programmatically', () => {
4841
timePicker.value = 'invalid';
4942
expect(timePicker.value).to.be.equal('');
5043
expect(inputElement.value).to.be.equal('');
5144
});
5245

53-
it('should change value to empty string when setting invalid value', () => {
54-
setInputValue(timePicker, '09:00');
55-
enter(inputElement);
56-
setInputValue(timePicker, 'invalid');
57-
enter(inputElement);
58-
expect(timePicker.value).to.be.equal('');
59-
});
60-
6146
it('should not allow setting invalid time value', () => {
6247
timePicker.value = '90:00';
6348
expect(timePicker.value).to.be.equal('');
@@ -91,30 +76,10 @@ describe('time-picker', () => {
9176
expect(inputElement.value).to.be.equal('12:00');
9277
});
9378

94-
it('should preserve invalid input value while resetting value to empty string', () => {
95-
timePicker.value = '12:00';
96-
setInputValue(timePicker, 'foo');
97-
enter(inputElement);
98-
expect(timePicker.value).to.equal('');
99-
expect(inputElement.value).to.equal('foo');
100-
});
101-
102-
it('should not restore the previous value in input field if input value is invalid', () => {
79+
it('should restore the previous value when setting invalid value', () => {
10380
timePicker.value = '12:00';
10481
timePicker.value = 'foo';
10582
expect(timePicker.value).to.be.equal('12:00');
106-
setInputValue(timePicker, 'bar');
107-
enter(inputElement);
108-
expect(timePicker.value).to.be.equal('');
109-
expect(inputElement.value).to.be.equal('bar');
110-
});
111-
112-
it('should set empty value on outside click after clearing input value', () => {
113-
timePicker.value = '12:00';
114-
setInputValue(timePicker, '');
115-
outsideClick();
116-
expect(timePicker.value).to.be.equal('');
117-
expect(inputElement.value).to.be.equal('');
11883
});
11984

12085
it('should dispatch value-changed when value changes', () => {
@@ -124,13 +89,6 @@ describe('time-picker', () => {
12489
expect(spy.calledOnce).to.be.true;
12590
});
12691

127-
it('should not call value-changed on keystroke input', () => {
128-
const spy = sinon.spy();
129-
timePicker.addEventListener('value-changed', spy);
130-
inputElement.value = '12:00';
131-
expect(spy.called).to.be.false;
132-
});
133-
13492
it('should be possible to update value', () => {
13593
timePicker.value = '12:00';
13694
expect(timePicker.value).to.be.equal('12:00');
@@ -174,14 +132,6 @@ describe('time-picker', () => {
174132
expect(spy.callCount).to.equal(2);
175133
});
176134

177-
it('should commit user input on Enter', async () => {
178-
inputElement.focus();
179-
await sendKeys({ type: '00:00' });
180-
expect(timePicker.value).to.equal('');
181-
await sendKeys({ press: 'Enter' });
182-
expect(timePicker.value).to.equal('00:00');
183-
});
184-
185135
it('should clear value with null', () => {
186136
timePicker.value = '12:00';
187137
timePicker.value = null;
@@ -278,13 +228,6 @@ describe('time-picker', () => {
278228
timePicker.clearButtonVisible = false;
279229
expect(comboBox.clearButtonVisible).to.be.false;
280230
});
281-
282-
it('should clear value on Escape if clear button is visible', async () => {
283-
timePicker.value = '00:00';
284-
inputElement.focus();
285-
await sendKeys({ press: 'Escape' });
286-
expect(timePicker.value).to.equal('');
287-
});
288231
});
289232

290233
describe('toggle button', () => {

0 commit comments

Comments
 (0)