@@ -234,35 +234,13 @@ describe('popover', () => {
234234 await nextRender ( ) ;
235235 } ) ;
236236
237- it ( 'should not close overlay on global Escape press by default' , async ( ) => {
237+ it ( 'should close overlay on global Escape press by default' , async ( ) => {
238238 esc ( document . body ) ;
239239 await nextRender ( ) ;
240- expect ( overlay . opened ) . to . be . true ;
241- } ) ;
242-
243- it ( 'should close overlay on global Escape press when modal is true' , async ( ) => {
244- popover . modal = true ;
245- await nextUpdate ( popover ) ;
246-
247- esc ( document . body ) ;
248- await nextRender ( ) ;
249- expect ( overlay . opened ) . to . be . false ;
250- } ) ;
251-
252- it ( 'should close overlay on internal Escape press by default' , async ( ) => {
253- esc ( overlay . $ . overlay ) ;
254- await nextRender ( ) ;
255- expect ( overlay . opened ) . to . be . false ;
256- } ) ;
257-
258- it ( 'should close overlay on target Escape press by default' , async ( ) => {
259- esc ( target ) ;
260- await nextRender ( ) ;
261240 expect ( overlay . opened ) . to . be . false ;
262241 } ) ;
263242
264243 it ( 'should not close on global Escape press if noCloseOnEsc is true' , async ( ) => {
265- popover . modal = true ;
266244 popover . noCloseOnEsc = true ;
267245 await nextUpdate ( popover ) ;
268246
@@ -271,20 +249,21 @@ describe('popover', () => {
271249 expect ( overlay . opened ) . to . be . true ;
272250 } ) ;
273251
274- it ( 'should not close overlay on internal Escape if noCloseOnEsc is true' , async ( ) => {
275- popover . noCloseOnEsc = true ;
252+ it ( 'should close overlay on global Escape press when modal is true' , async ( ) => {
253+ popover . modal = true ;
276254 await nextUpdate ( popover ) ;
277255
278- esc ( overlay . $ . overlay ) ;
256+ esc ( document . body ) ;
279257 await nextRender ( ) ;
280- expect ( overlay . opened ) . to . be . true ;
258+ expect ( overlay . opened ) . to . be . false ;
281259 } ) ;
282260
283- it ( 'should not close overlay on target Escape if noCloseOnEsc is true' , async ( ) => {
261+ it ( 'should not close on global Escape press if noCloseOnEsc is true when moodal' , async ( ) => {
262+ popover . modal = true ;
284263 popover . noCloseOnEsc = true ;
285264 await nextUpdate ( popover ) ;
286265
287- esc ( target ) ;
266+ esc ( document . body ) ;
288267 await nextRender ( ) ;
289268 expect ( overlay . opened ) . to . be . true ;
290269 } ) ;
0 commit comments