Skip to content

Commit cc54b20

Browse files
authored
fix: prevent slotted icon from shrinking with long text (#6083)
1 parent cec255b commit cc54b20

3 files changed

Lines changed: 11 additions & 3 deletions

File tree

7.77 KB
Loading

‎packages/side-nav/test/visual/lumo/side-nav.test.js‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ describe('side-nav', () => {
2323
<span slot="label">Messages</span>
2424
<vaadin-side-nav-item path="/inbox">
2525
<vaadin-icon icon="vaadin:inbox" slot="prefix"></vaadin-icon>
26-
Inbox
26+
<span>Inbox</span>
2727
</vaadin-side-nav-item>
2828
<vaadin-side-nav-item path="/sent">
2929
<vaadin-icon icon="vaadin:paperplane" slot="prefix"></vaadin-icon>
30-
Sent
30+
<span>Sent</span>
3131
</vaadin-side-nav-item>
3232
<vaadin-side-nav-item path="/trash">
3333
<vaadin-icon icon="vaadin:trash" slot="prefix"></vaadin-icon>
34-
Trash
34+
<span>Trash</span>
3535
</vaadin-side-nav-item>
3636
</vaadin-side-nav>
3737
`,
@@ -56,6 +56,13 @@ describe('side-nav', () => {
5656
item.setAttribute('current', '');
5757
await visualDiff(div, 'current-item');
5858
});
59+
60+
it('overflowing item', async () => {
61+
const span = document.querySelector('vaadin-side-nav-item span');
62+
span.textContent = 'Very long item that does not fit';
63+
element.style.maxWidth = '200px';
64+
await visualDiff(div, 'overflowing-item');
65+
});
5966
});
6067

6168
['ltr', 'rtl'].forEach((dir) => {

‎packages/side-nav/theme/lumo/vaadin-side-nav-item-styles.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ export const sideNavItemStyles = css`
8080
8181
slot[name='prefix']::slotted(:is(vaadin-icon, [class*='icon'])) {
8282
padding: 0.1em;
83+
flex-shrink: 0;
8384
color: var(--lumo-contrast-60pct);
8485
}
8586

0 commit comments

Comments
 (0)