Skip to content

Commit ddedb46

Browse files
authored
fix: hide placeholder item when select is readonly or disabled (#5426)
1 parent 4e27177 commit ddedb46

4 files changed

Lines changed: 16 additions & 0 deletions

File tree

593 Bytes
Loading
812 Bytes
Loading

‎packages/select/test/visual/lumo/select.test.js‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,18 @@ describe('select', () => {
5959
await visualDiff(div, 'placeholder');
6060
});
6161

62+
it('readonly placeholder', async () => {
63+
element.placeholder = 'Placeholder';
64+
element.readonly = true;
65+
await visualDiff(div, 'readonly-placeholder');
66+
});
67+
68+
it('disabled placeholder', async () => {
69+
element.placeholder = 'Placeholder';
70+
element.disabled = true;
71+
await visualDiff(div, 'disabled-placeholder');
72+
});
73+
6274
it('value', async () => {
6375
element.value = 'value-1';
6476
await visualDiff(div, 'value');

‎packages/select/theme/lumo/vaadin-select-styles.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ const select = css`
4242
color: var(--lumo-secondary-text-color);
4343
}
4444
45+
:host(:is([readonly], [disabled])) ::slotted([slot='value'][placeholder]) {
46+
opacity: 0;
47+
}
48+
4549
[part='toggle-button']::before {
4650
content: var(--lumo-icons-dropdown);
4751
}

0 commit comments

Comments
 (0)