Skip to content

Commit e04a4a9

Browse files
authored
fix: make dialog renderer owner argument required (#4919)
1 parent e60b809 commit e04a4a9

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

‎packages/dialog/src/vaadin-dialog.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { DialogResizableMixin } from './vaadin-dialog-resizable-mixin.js';
1414
*/
1515
export class DialogOverlay extends Overlay {}
1616

17-
export type DialogRenderer = (root: HTMLElement, dialog?: Dialog) => void;
17+
export type DialogRenderer = (root: HTMLElement, dialog: Dialog) => void;
1818

1919
export type DialogResizableDirection = 'e' | 'n' | 'ne' | 'nw' | 's' | 'se' | 'sw' | 'w';
2020

‎packages/dialog/test/typings/dialog.types.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import '../../vaadin-dialog.js';
22
import type {
3+
Dialog,
34
DialogOpenedChangedEvent,
45
DialogRenderer,
56
DialogResizeDimensions,
@@ -26,3 +27,10 @@ assertType<DialogRenderer | null | undefined>(dialog.renderer);
2627
assertType<DialogRenderer | null | undefined>(dialog.headerRenderer);
2728
assertType<DialogRenderer | null | undefined>(dialog.footerRenderer);
2829
assertType<() => void>(dialog.requestContentUpdate);
30+
31+
const renderer: DialogRenderer = (root, owner) => {
32+
assertType<HTMLElement>(root);
33+
assertType<Dialog>(owner);
34+
};
35+
36+
dialog.renderer = renderer;

0 commit comments

Comments
 (0)