Skip to content

Commit e25f531

Browse files
authored
refactor: do not set hidden attribute on the overlay (#4249)
1 parent f127548 commit e25f531

7 files changed

Lines changed: 23 additions & 34 deletions

File tree

‎packages/combo-box/src/vaadin-combo-box-light.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ class ComboBoxLight extends ComboBoxDataProviderMixin(ComboBoxMixin(ValidateMixi
8282
8383
<vaadin-combo-box-overlay
8484
id="overlay"
85-
hidden$="[[_isOverlayHidden(filteredItems, loading)]]"
8685
opened="[[_overlayOpened]]"
8786
loading$="[[loading]]"
8887
theme$="[[_theme]]"

‎packages/combo-box/src/vaadin-combo-box.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,6 @@ class ComboBox extends ComboBoxDataProviderMixin(
202202
203203
<vaadin-combo-box-overlay
204204
id="overlay"
205-
hidden$="[[_isOverlayHidden(filteredItems, loading)]]"
206205
opened="[[_overlayOpened]]"
207206
loading$="[[loading]]"
208207
theme$="[[_theme]]"

‎packages/combo-box/test/dom/__snapshots__/combo-box.test.snap.js‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,6 @@ snapshots["vaadin-combo-box shadow default"] =
439439
</div>
440440
</div>
441441
<vaadin-combo-box-overlay
442-
hidden=""
443442
id="overlay"
444443
no-vertical-overlap=""
445444
>
@@ -500,7 +499,6 @@ snapshots["vaadin-combo-box shadow disabled"] =
500499
</div>
501500
</div>
502501
<vaadin-combo-box-overlay
503-
hidden=""
504502
id="overlay"
505503
no-vertical-overlap=""
506504
>
@@ -561,7 +559,6 @@ snapshots["vaadin-combo-box shadow readonly"] =
561559
</div>
562560
</div>
563561
<vaadin-combo-box-overlay
564-
hidden=""
565562
id="overlay"
566563
no-vertical-overlap=""
567564
>
@@ -622,7 +619,6 @@ snapshots["vaadin-combo-box shadow invalid"] =
622619
</div>
623620
</div>
624621
<vaadin-combo-box-overlay
625-
hidden=""
626622
id="overlay"
627623
no-vertical-overlap=""
628624
>
@@ -683,7 +679,6 @@ snapshots["vaadin-combo-box shadow theme"] =
683679
</div>
684680
</div>
685681
<vaadin-combo-box-overlay
686-
hidden=""
687682
id="overlay"
688683
no-vertical-overlap=""
689684
theme="align-right"

‎packages/combo-box/test/internal-filtering.test.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,10 +258,11 @@ describe('internal filtering', () => {
258258
expect(comboBox.filteredItems).to.be.null;
259259
});
260260

261-
it('should hide overlay when filtered items length is 0', () => {
261+
it('should close overlay when filtered items length is 0', () => {
262262
setInputValue(comboBox, 'THIS IS NOT FOUND');
263263

264-
expect(comboBox.opened && overlay.hasAttribute('hidden')).to.be.true;
264+
expect(comboBox.opened).to.be.true;
265+
expect(overlay.opened).to.be.false;
265266
});
266267

267268
it('should reset the filter on value change', () => {

‎packages/combo-box/test/toggling-dropdown.test.js‎

Lines changed: 20 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,15 @@ describe('toggling dropdown', () => {
2525
expect(comboBox.opened).to.be.false;
2626
tap(comboBox.querySelector('[slot="label"]'));
2727
expect(comboBox.opened).to.be.true;
28+
expect(overlay.opened).to.be.true;
2829
});
2930

3031
it('should not open synchronously by clicking label when autoOpenDisabled is true', () => {
3132
comboBox.autoOpenDisabled = true;
3233
expect(comboBox.opened).to.be.false;
3334
tap(comboBox.querySelector('[slot="label"]'));
3435
expect(comboBox.opened).to.be.false;
36+
expect(overlay.opened).to.be.false;
3537
});
3638

3739
it('should restore attribute focus-ring if it was initially set before opening and combo-box is focused', () => {
@@ -45,19 +47,22 @@ describe('toggling dropdown', () => {
4547
expect(comboBox.opened).to.be.false;
4648
tap(input);
4749
expect(comboBox.opened).to.be.true;
50+
expect(overlay.opened).to.be.true;
4851
});
4952

5053
it('should not open synchronously by clicking input when autoOpenDisabled is true', () => {
5154
comboBox.autoOpenDisabled = true;
5255
expect(comboBox.opened).to.be.false;
5356
tap(input);
5457
expect(comboBox.opened).to.be.false;
58+
expect(overlay.opened).to.be.false;
5559
});
5660

5761
it('should open by clicking icon', () => {
5862
clickToggleIcon();
5963

6064
expect(comboBox.opened).to.be.true;
65+
expect(overlay.opened).to.be.true;
6166
});
6267

6368
it('should open by clicking icon when autoOpenDisabled is true and input is invalid', () => {
@@ -103,6 +108,7 @@ describe('toggling dropdown', () => {
103108
comboBox.open();
104109

105110
expect(comboBox.opened).to.be.true;
111+
expect(overlay.opened).to.be.true;
106112
});
107113

108114
it('should set body `pointer-events: none` on open and restore initial value on close', () => {
@@ -127,22 +133,31 @@ describe('toggling dropdown', () => {
127133
expect(comboBox.opened).to.be.true;
128134
});
129135

130-
it('should be hidden with null items', () => {
136+
it('should not open overlay when setting items to null', () => {
131137
comboBox.items = null;
132138

133139
comboBox.open();
134140

135141
expect(comboBox.opened).to.be.true;
136-
expect(overlay.hasAttribute('hidden')).to.be.true;
142+
expect(overlay.opened).to.be.false;
137143
});
138144

139-
it('should be hidden with no items', () => {
145+
it('should not open overlay when setting empty items array', () => {
140146
comboBox.items = [];
141147

142148
comboBox.open();
143149

144150
expect(comboBox.opened).to.be.true;
145-
expect(overlay.hasAttribute('hidden')).to.be.true;
151+
expect(overlay.opened).to.be.false;
152+
});
153+
154+
it('should not open overlay when setting empty filteredItems array', () => {
155+
comboBox.filteredItems = [];
156+
157+
comboBox.open();
158+
159+
expect(comboBox.opened).to.be.true;
160+
expect(overlay.opened).to.be.false;
146161
});
147162

148163
(isIOS ? describe : describe.skip)('after opening', () => {
@@ -223,7 +238,7 @@ describe('toggling dropdown', () => {
223238

224239
focusout(input);
225240

226-
expect(comboBox.opened).to.equal(false);
241+
expect(comboBox.opened).to.be.false;
227242
});
228243

229244
it('should restore focus to the field on outside click', async () => {
@@ -323,24 +338,6 @@ describe('toggling dropdown', () => {
323338
});
324339
});
325340

326-
describe('empty list', () => {
327-
it('vaadin-combo-box-overlay should not be attached when filteredItems is empty', () => {
328-
comboBox.open();
329-
expect(comboBox.opened).to.be.true;
330-
expect(document.querySelector('vaadin-combo-box-overlay')).to.be.ok;
331-
comboBox.close();
332-
expect(comboBox.opened).to.be.false;
333-
expect(document.querySelector('vaadin-combo-box-overlay')).not.to.be.ok;
334-
335-
comboBox.filteredItems = [];
336-
comboBox.open();
337-
expect(comboBox.opened).to.be.true;
338-
expect(document.querySelector('vaadin-combo-box-overlay')).not.to.be.ok;
339-
comboBox.close();
340-
expect(comboBox.opened).to.be.false;
341-
});
342-
});
343-
344341
(isIOS ? describe : describe.skip)('external focus (initially)', () => {
345342
let input, blurSpy;
346343

‎packages/multi-select-combo-box/src/vaadin-multi-select-combo-box-internal.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ class MultiSelectComboBoxInternal extends ComboBoxDataProviderMixin(ComboBoxMixi
3838
3939
<vaadin-multi-select-combo-box-overlay
4040
id="overlay"
41-
hidden$="[[_isOverlayHidden(filteredItems, loading)]]"
4241
opened="[[_overlayOpened]]"
4342
loading$="[[loading]]"
4443
theme$="[[_theme]]"

‎packages/time-picker/src/vaadin-time-picker-combo-box.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ class TimePickerComboBox extends ComboBoxMixin(ThemableMixin(PolymerElement)) {
3535
3636
<vaadin-time-picker-overlay
3737
id="overlay"
38-
hidden$="[[_isOverlayHidden(filteredItems, loading)]]"
3938
opened="[[_overlayOpened]]"
4039
loading$="[[loading]]"
4140
theme$="[[_theme]]"

0 commit comments

Comments
 (0)