Skip to content

Commit f50e0d8

Browse files
authored
fix: add missing mixins to SelectBaseMixin types (#6353)
1 parent 67ae167 commit f50e0d8

2 files changed

Lines changed: 25 additions & 0 deletions

File tree

‎packages/select/src/vaadin-select-base-mixin.d.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@
55
*/
66
import type { Constructor } from '@open-wc/dedupe-mixin';
77
import type { DelegateFocusMixinClass } from '@vaadin/a11y-base/src/delegate-focus-mixin.js';
8+
import type { DisabledMixinClass } from '@vaadin/a11y-base/src/disabled-mixin.js';
9+
import type { FocusMixinClass } from '@vaadin/a11y-base/src/focus-mixin.js';
810
import type { KeyboardMixinClass } from '@vaadin/a11y-base/src/keyboard-mixin.js';
11+
import type { TabindexMixinClass } from '@vaadin/a11y-base/src/tabindex-mixin.js';
912
import type { DelegateStateMixinClass } from '@vaadin/component-base/src/delegate-state-mixin.js';
1013
import type { OverlayClassMixinClass } from '@vaadin/component-base/src/overlay-class-mixin.js';
1114
import type { FieldMixinClass } from '@vaadin/field-base/src/field-mixin.js';
@@ -17,11 +20,14 @@ export declare function SelectBaseMixin<T extends Constructor<HTMLElement>>(
1720
base: T,
1821
): Constructor<DelegateFocusMixinClass> &
1922
Constructor<DelegateStateMixinClass> &
23+
Constructor<DisabledMixinClass> &
2024
Constructor<FieldMixinClass> &
25+
Constructor<FocusMixinClass> &
2126
Constructor<KeyboardMixinClass> &
2227
Constructor<LabelMixinClass> &
2328
Constructor<OverlayClassMixinClass> &
2429
Constructor<SelectBaseMixinClass> &
30+
Constructor<TabindexMixinClass> &
2531
Constructor<ValidateMixinClass> &
2632
T;
2733

‎packages/select/test/typings/select.types.ts‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
import '../../vaadin-select.js';
2+
import type { DelegateFocusMixinClass } from '@vaadin/a11y-base/src/delegate-focus-mixin.js';
3+
import type { DisabledMixinClass } from '@vaadin/a11y-base/src/disabled-mixin.js';
4+
import type { FocusMixinClass } from '@vaadin/a11y-base/src/focus-mixin.js';
5+
import type { KeyboardMixinClass } from '@vaadin/a11y-base/src/keyboard-mixin.js';
26
import type { ListMixinClass } from '@vaadin/a11y-base/src/list-mixin.js';
7+
import type { TabindexMixinClass } from '@vaadin/a11y-base/src/tabindex-mixin.js';
8+
import type { DelegateStateMixinClass } from '@vaadin/component-base/src/delegate-state-mixin.js';
39
import type { DirMixinClass } from '@vaadin/component-base/src/dir-mixin.js';
10+
import type { OverlayClassMixinClass } from '@vaadin/component-base/src/overlay-class-mixin.js';
11+
import type { FieldMixinClass } from '@vaadin/field-base/src/field-mixin.js';
12+
import type { LabelMixinClass } from '@vaadin/field-base/src/label-mixin.js';
413
import type { ValidateMixinClass } from '@vaadin/field-base/src/validate-mixin.js';
514
import type { ItemMixinClass } from '@vaadin/item/src/vaadin-item-mixin.js';
615
import type { ThemableMixinClass } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
@@ -36,6 +45,16 @@ assertType<() => void>(select.requestContentUpdate);
3645
assertType<() => boolean>(select.validate);
3746

3847
// Mixins
48+
assertType<DelegateFocusMixinClass>(select);
49+
assertType<DelegateStateMixinClass>(select);
50+
assertType<DisabledMixinClass>(select);
51+
assertType<FieldMixinClass>(select);
52+
assertType<FocusMixinClass>(select);
53+
assertType<KeyboardMixinClass>(select);
54+
assertType<LabelMixinClass>(select);
55+
assertType<OverlayClassMixinClass>(select);
56+
assertType<TabindexMixinClass>(select);
57+
assertType<ThemableMixinClass>(select);
3958
assertType<ValidateMixinClass>(select);
4059

4160
// Item properties

0 commit comments

Comments
 (0)