Skip to content

Commit 766b8d2

Browse files
Copilothi-ogawa
andauthored
fix(ui): render ANSI color codes in editor panel inline error widget (#10418)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: hi-ogawa <4232207+hi-ogawa@users.noreply.github.com> Co-authored-by: Hiroshi Ogawa <hi.ogawa.zz@gmail.com>
1 parent ac6971c commit 766b8d2

3 files changed

Lines changed: 14 additions & 5 deletions

File tree

‎packages/ui/client/components/views/ViewEditor.vue‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import { getAttachmentUrl, sanitizeFilePath } from '~/composables/attachments'
99
import { client, config, isReport } from '~/composables/client'
1010
import { finished } from '~/composables/client/state'
1111
import { codemirrorRef } from '~/composables/codemirror'
12-
import { openInEditor } from '~/composables/error'
12+
import { isDark } from '~/composables/dark'
13+
import { createAnsiToHtmlFilter, openInEditor } from '~/composables/error'
1314
import { columnNumber, lineNumber } from '~/composables/params'
1415
import {
1516
activeTraceView,
@@ -18,6 +19,7 @@ import {
1819
isTraceViewEnabled,
1920
selectActiveTraceStep,
2021
} from '~/composables/trace-view'
22+
import { escapeHtml } from '~/utils/escape'
2123
import CodeMirrorContainer from '../CodeMirrorContainer.vue'
2224
2325
const props = defineProps<{
@@ -225,12 +227,12 @@ function createErrorElement(e: TestError) {
225227
return
226228
}
227229
const div = document.createElement('div')
230+
div.dataset.testid = 'error-line-gadget'
228231
div.className = 'op80 flex gap-x-2 items-center'
229232
const pre = document.createElement('pre')
230233
pre.className = 'c-red-700 dark:c-red-400'
231-
pre.textContent = `${' '.repeat(stack.column)}^ ${e.name}: ${
232-
e?.message || ''
233-
}`
234+
const filter = createAnsiToHtmlFilter(isDark.value)
235+
pre.innerHTML = `${' '.repeat(stack.column)}^ ${filter.toHtml(escapeHtml(`${e.name}: ${e.message}`))}`
234236
div.appendChild(pre)
235237
const span = document.createElement('span')
236238
span.className

‎test/ui/playwright.config.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export default defineConfig({
1010
},
1111
],
1212
use: {
13-
trace: process.env.CI ? 'on-first-retry' : 'on',
13+
trace: process.env.CI ? 'on-first-retry' : undefined,
1414
},
1515
forbidOnly: !!process.env.CI,
1616
retries: process.env.CI ? 2 : 0,

‎test/ui/test/ui.spec.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -391,6 +391,13 @@ async function testError(page: Page) {
391391

392392
await getExplorerItem(page, 'colored error message').click()
393393
await expect(page.getByTestId('report')).toHaveText('Error: this-is-blue - /node/error.test.ts:12:17')
394+
395+
// switch to Code tab and verify ANSI is rendered as HTML in the editor line widget
396+
await page.getByTestId('btn-code').click()
397+
await expect(page.getByTestId('editor').getByTestId('error-line-gadget')).toHaveText([
398+
/AssertionError: expected/,
399+
/Error: this-is-blue/,
400+
])
394401
}
395402

396403
async function testTagsFilter(page: Page) {

0 commit comments

Comments
 (0)