Skip to content

Add Git Parameter to the managed set - #3891

Merged
darinpope merged 2 commits into
jenkinsci:masterfrom
darinpope:add-git-parameter
Nov 1, 2024
Merged

darinpope merged 2 commits into
jenkinsci:masterfrom
darinpope:add-git-parameter

Conversation

@darinpope

Copy link
Copy Markdown
Contributor

Add Git Parameter to the managed set

Testing done

  • LINE=weekly PLUGINS=git-parameter bash local-test.sh
  • LINE=2.479.x PLUGINS=git-parameter bash local-test.sh
  • LINE=2.462.x PLUGINS=git-parameter bash local-test.sh
  • LINE=2.452.x PLUGINS=git-parameter bash local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@darinpope
darinpope requested a review from a team as a code owner October 31, 2024 18:41
@darinpope darinpope added the full-test Test all LTS lines in this PR and do not halt upon first error. label Oct 31, 2024
@darinpope
darinpope enabled auto-merge (squash) November 1, 2024 11:00
@darinpope
darinpope disabled auto-merge November 1, 2024 16:18
@darinpope
darinpope merged commit 7e97f0b into jenkinsci:master Nov 1, 2024
@darinpope

Copy link
Copy Markdown
Contributor Author

I manually merged because the two failures in build 2 (asm-api-2.479.x and echarts-api-2.462.x) both passed in build 1. ASM was a ClosedChannelException and echarts was unable to download NodeJS.

@darinpope
darinpope deleted the add-git-parameter branch November 1, 2024 16:20
@MarkEWaite MarkEWaite added the enhancement New feature or request label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants