Repository navigation
Share namespace scope tracking with W3CDom - #2559
Merged
Merged
Conversation
Extract the optimized binding tracker from XmlTreeBuilder into a shared internal helper and use it during W3C conversion. The shared tracker removes repeated ancestor lookups and gives W3CDom reliable namespace state, making conversion both more efficient and more correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the XML namespace scope optimization in #2556.
XmlTreeBuilderandW3Dom.W3CBuilderboth need to track namespace bindings as elements open and close. This extracts that work into a sharedNamespaceBindingshelper instead of maintaining two implementations.The helper keeps one active bindings map and records only the changes needed to restore each parent scope. This preserves the XML parser’s improved memory use and processing time while making the same scoped lookup available to the W3C converter.
W3CDomuses one tracker for source bindings and another for declarations already emitted into the W3C tree. That replaces repeated ancestor searches with direct lookups and avoids emitting unnecessary declarations.W3C DOM fixes
This also fixes namespace conversion in several cases:
a:b:cbecomesa:b_c.