Repository navigation
Replace Path.toFile() - #1158
Merged
Merged
Conversation
In some use cases it's preferable to have for example the nanorc configs inside a jar. Although a lot of the code base use `java.nio.file.Path`, a couple of places still call `Path.toFile()`, which isn't supported for NIO's ZIP file system, which can be created for a `jar:` URL, so that the contents of the jar can be used as a (read only) file system. This PR replaces occurences of `Path.toFile()` and replaces the `File` operations with NIO's `Files`.
cstamas
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some use cases it's preferable to have for example the nanorc configs inside a jar. Although a lot of the code base use
java.nio.file.Path, a couple of places still callPath.toFile(), which isn't supported for NIO's ZIP file system, which can be created for ajar:URL, so that the contents of the jar can be used as a (read only) file system.This PR replaces occurences of
Path.toFile()and replaces theFileoperations with NIO'sFiles.