Skip to content

LocustBadStatusCode without url param in fasthttp - #2944

Merged
cyberw merged 5 commits into
locustio:masterfrom
swaalt:LocustBadStatusCode-without-url
Oct 18, 2024
Merged

cyberw merged 5 commits into
locustio:masterfrom
swaalt:LocustBadStatusCode-without-url

Conversation

@swaalt

@swaalt swaalt commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

a new function _verify_status was created and a LocustBadStatusCode class is sent as a response to the function which removes the url leaving only the code.

@cyberw

cyberw commented Oct 17, 2024

Copy link
Copy Markdown
Collaborator

👍 just add a test case to test_fasthttpuser (or add some validation it to some existing one) and format using ruff and I’ll merge.

@cyberw

cyberw commented Oct 17, 2024

Copy link
Copy Markdown
Collaborator

Hmm... looks like every Python version failed, that's a bit worrying, but may still be irrelevant.

Can you write the test this way instead?

def test_error_message(self):

@cyberw

cyberw commented Oct 17, 2024

Copy link
Copy Markdown
Collaborator

No I didnt mean the name, I meant the way of testing :)

@cyberw
cyberw merged commit 0f506c5 into locustio:master Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants