Skip to content

Webui Echarts Redraw Request Lines if Changed - #2953

Merged
cyberw merged 1 commit into
locustio:masterfrom
andrewbaldwin44:bugfix/redraw-request-lines
Oct 24, 2024
Merged

cyberw merged 1 commit into
locustio:masterfrom
andrewbaldwin44:bugfix/redraw-request-lines

Conversation

@andrewbaldwin44

@andrewbaldwin44 andrewbaldwin44 commented Oct 24, 2024 •

Copy link
Copy Markdown
Collaborator

Proposal

  • If the chart lines change during a render, echarts merges the lines with the existing ones by default. This adds a prop that allows for the lines to be redrawn in the case that they have completely changed
  • Remove the isDarkMode prop from drawing marked lines. The marked lines infer their color from the base axis lineStyle, so removing this prop will save us a useEffect cycle

@andrewbaldwin44
andrewbaldwin44 force-pushed the bugfix/redraw-request-lines branch 2 times, most recently from 3d32731 to d037290 Compare October 24, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants