Repository navigation
Public backoff config to allow usage of WithAPIBackoff - #1895
Merged
Merged
Conversation
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
pipiland2612
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
October 17, 2025 08:24
Contributor
Author
|
Another option is to define an interface that allows passing in the WithBackoff method. However, this approach feels less clean and adds unnecessary complexity for the client, since our goal is only to modify the configuration—not the underlying implementation. |
Member
|
Can you update title and description (and commit message)? It's out of date (description) and title is not human readable. |
bwplotka
approved these changes
Oct 17, 2025
bwplotka
left a comment
bwplotka
left a comment
Member
There was a problem hiding this comment.
Amazing, looks good, just readability nits!
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
pipiland2612
changed the title
bwplotka
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Issue is this fixing ?
func WithAPIBackoff(cfg BackoffConfig)without the error: "Use of the internal package is not allowed"Changes