Skip to content

Fix incorrect document regarding pyodide auditwheel - #2752

Merged
ryanking13 merged 4 commits into
pypa:mainfrom
ryanking13:pyodide-audithweel
Mar 3, 2026
Merged

ryanking13 merged 4 commits into
pypa:mainfrom
ryanking13:pyodide-audithweel

Conversation

@ryanking13

Copy link
Copy Markdown
Member

Pyodide does not run auditwheel by default as we don't know where to locate the cross-compiled libraries, it needs to be done by the user.

@agriyakhetarpal agriyakhetarpal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ryanking13! Makes sense. Side note: any reason why we are at auditwheel-emscripten==0.2.1 in cibuildwheel and not v0.2.3?

@agriyakhetarpal

Copy link
Copy Markdown
Member

Note that the test is failing; should be a quick fix though.

@ryanking13

Copy link
Copy Markdown
Member Author

Thanks, @ryanking13! Makes sense. Side note: any reason why we are at auditwheel-emscripten==0.2.1 in cibuildwheel and not v0.2.3?

No reason, I guess #2734 will pickup the latest version soon?

@joerick

joerick commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

Docs change looks good, thanks. But there's a test failure on the test that was added in this PR.

@henryiii
henryiii force-pushed the pyodide-audithweel branch from f88a1a9 to de53439 Compare March 2, 2026 22:06
@ryanking13
ryanking13 merged commit 95b4b79 into pypa:main Mar 3, 2026
43 checks passed
@ryanking13
ryanking13 deleted the pyodide-audithweel branch March 3, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants