TextFormatter: cover nil pointer method receivers - #1584
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Extends Logrus’ TextFormatter regression test coverage around error / fmt.Stringer formatting to include nil pointer values where the interface method set comes from either pointer-receiver or value-receiver implementations, ensuring formatting remains non-panicking and stable.
Changes:
- Expands
TestTextFormatterPanickingValuetable cases to include nil pointers that satisfyerror/fmt.Stringervia value-receiver methods (in addition to pointer-receiver methods). - Adds dedicated helper types (
nilValueError,nilValueStringer) to model the value-receiver-on-nil-pointer scenario described in the regression context. - Clarifies test case descriptions to differentiate pointer-receiver vs value-receiver nil scenarios.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Extend the regression test for panicking Error and String methods to cover nil pointers with both pointer- and value-receiver implementations. This includes the value-receiver case that triggered the reported regression, such as *net.IP. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
more_coverage
branch
from
August 19, 2026 08:46
eb0f8e9 to
5e20694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the regression test for panicking Error and String methods to cover nil pointers with both pointer- and value-receiver implementations.
This includes the value-receiver case that triggered the reported regression, such as *net.IP.