Skip to content

[ruff] Avoid treating named expressions as static keys (RUF011) - #9494

Merged
charliermarsh merged 1 commit into
mainfrom
charlie/static
Jan 12, 2024
Merged

charliermarsh merged 1 commit into
mainfrom
charlie/static

Conversation

@charliermarsh

Copy link
Copy Markdown
Member

Closes #9487.

@charliermarsh charliermarsh added the bug An issue describing something that isn't working, or a PR that fixes a bug label Jan 12, 2024
@charliermarsh
charliermarsh marked this pull request as ready for review January 12, 2024 18:20
@codspeed

codspeed Bot commented Jan 12, 2024 •

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #9494 will degrade performances by 4.35%

Comparing charlie/static (439da72) with main (fee64b5)

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main charlie/static Change
❌ parser[numpy/ctypeslib.py] 12.2 ms 12.8 ms -4.35%

@github-actions

github-actions Bot commented Jan 12, 2024 •

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -1 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

bokeh/bokeh (+0 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --no-preview --select ALL

- src/bokeh/core/serialization.py:666:34: PD002 `inplace=True` should be avoided; it has inconsistent behavior

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PD002 1 0 1 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -1 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

bokeh/bokeh (+0 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --preview --select ALL

- src/bokeh/core/serialization.py:666:34: PD002 `inplace=True` should be avoided; it has inconsistent behavior

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
PD002 1 0 1 0 0

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh
charliermarsh marked this pull request as draft January 12, 2024 18:35
@charliermarsh
charliermarsh marked this pull request as ready for review January 12, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue describing something that isn't working, or a PR that fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positives in 0.1.12 with RUF011

1 participant