Repository navigation
[ruff] Avoid treating named expressions as static keys (RUF011) - #9494
Merged
Merged
Conversation
charliermarsh
marked this pull request as ready for review
January 12, 2024 18:20
CodSpeed Performance ReportMerging #9494 will degrade performances by 4.35%Comparing Summary
Benchmarks breakdown
|
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PD002 | 1 | 0 | 1 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -1 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)
bokeh/bokeh (+0 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --preview --select ALL
- src/bokeh/core/serialization.py:666:34: PD002 `inplace=True` should be avoided; it has inconsistent behavior
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PD002 | 1 | 0 | 1 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
charliermarsh
marked this pull request as draft
January 12, 2024 18:35
charliermarsh
force-pushed
the
charlie/static
branch
from
January 12, 2024 18:43
47f7754 to
4b432b5
Compare
charliermarsh
marked this pull request as ready for review
January 12, 2024 18:46
charliermarsh
force-pushed
the
charlie/static
branch
from
January 12, 2024 19:15
4b432b5 to
439da72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9487.