[sarah (satvu)]

Summary

• add phase-aware updater progress models for download, extract, install, and verification
• report cumulative downloaded bytes through a transparent read-stream wrapper
• thread optional progress reporting through ICliUpdater and CliUpdater
• add focused coverage for phase ordering and download byte totals

Stack

Layer 2/4 of the replacement stack for #5458.

Depends on #5609. Base: satvu-harden-updater-reliability; head: satvu-report-updater-progress.

Validation

• dotnet restore
• dotnet test test\Func.Tests\Func.Tests.csproj -c Release --no-restore --filter "FullyQualifiedName~CliUpdaterTests" --logger "console;verbosity=minimal" (14 passed)
• $env:CI='true'; dotnet build -c Release --no-restore (0 warnings, 0 errors)

[Copilot]

Note

Copilot was unable to run its full agentic suite in this review.

Copilot review overview

Review effort: Lite
Findings: 4

Open (4)

• When progress is not null, source becomes a ProgressReadStream that is never disposed. Even… · New
• Since progress is documented as optional, consider making it an optional parameter with a default… · New
• CanSeek is false, but Length delegates to _inner.Length. If _inner is non-seekable… · New
• The test hard-codes the expected byte count (22), which is brittle if the stubbed download… · New

What changed in this PR

Adds opt-in progress reporting to the CLI updater so callers can observe update phases and download byte counts.

Changes:

• Extends ICliUpdater.UpdateAsync / CliUpdater.UpdateAsync with an optional progress sink parameter.
• Introduces UpdatePhase / UpdateProgress types and a ProgressReadStream wrapper to report cumulative download bytes.
• Adds a functional test validating phase transitions and download byte reporting.

File	Description
test/​Func.Tests/​Update/​CliUpdaterTests.cs	Updates existing tests for the new UpdateAsync signature and adds coverage for progress reporting.
src/​Func/​Update/​UpdateProgress.cs	Adds progress DTOs (UpdatePhase, UpdateProgress) used by the updater and any UI/consumers.
src/​Func/​Update/​ProgressReadStream.cs	Adds a stream wrapper that reports incremental download progress while reading.
src/​Func/​Update/​ICliUpdater.cs	Updates the updater interface to accept a progress sink.
src/​Func/​Update/​CliUpdater.cs	Implements phase + byte progress reporting during update execution and download.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Lilian Kasem (liliankasem)]

mostly lgtm! just needs more/better testing

[Copilot]

Copilot review overview

🟡 Changes recommended

The progress test does not verify cumulative byte counts across multiple reads.

Review effort: Balanced
Findings: 1

Open (1)

• Test fails to verify cumulative byte-progress reporting · New

[Copilot]

Copilot review overview

🟢 Approval recommended

The changes are narrowly scoped, preserve existing updater safeguards, and include focused progress coverage.

Review effort: Balanced
Findings: None

Resolved since last review (1)

• Test fails to verify cumulative byte-progress reporting