Compatibility issue Orbit Fox- Elementor Pro #844

Activity

1. AndreeaCristinaRadacina

   added

   bugThis label could be used to identify issues that are caused by a defect in the product.This label could be used to identify issues that are caused by a defect in the product.

   on Apr 15, 2024
2. AndreeaCristinaRadacina commented on Apr 15, 2024

   

   AndreeaCristinaRadacina

   on Apr 15, 2024

   Author

   More actions

   +1 https://secure.helpscout.net/conversation/2570353120/413830?viewId=931544
3. pirate-bot

   added

   customer reportIndicates the request came from a customer.Indicates the request came from a customer.

   regressionIssue represents a change in behavior from a previous version that is not intended or desired..Issue represents a change in behavior from a previous version that is not intended or desired..

   on Apr 15, 2024
4. vytisbulkevicius

   removed

   regressionIssue represents a change in behavior from a previous version that is not intended or desired..Issue represents a change in behavior from a previous version that is not intended or desired..

   on Apr 15, 2024
5. vytisbulkevicius commented on Apr 15, 2024

   

   vytisbulkevicius

   on Apr 15, 2024

   Contributor

   More actions

   @AndreeaCristinaRadacina,

   We haven't made a release for 3 weeks, so I wouldn't call this a regression. I see Elementor made a release today and both tickets are submitted today, so it seems like the issue was introduced by Elementor release.

   Also, the error is also thrown by Elementor not OrbitFox:
   

   @preda-bogdan, can you also take a look when you can to see if it's a problem that should be fixed from our end?

   👍React with 👍2Reacted by AndreeaRădăcină and Bogdan Preda
6. preda-bogdan commented on Apr 16, 2024

   

   preda-bogdan

   on Apr 16, 2024

   Last edited by preda-bogdan

   Contributor

   More actions

   @vytisbulkevicius it is caused by https://github.com/Codeinwp/elementor-extra-widgets which is a dependency of OBFX and it will trigger and error inside the new version of Elementor Pro because of this line here:https://github.com/Codeinwp/elementor-extra-widgets/blob/master/class-elementor-extra-widgets.php#L139 this should return the $data instead of NULL to not crash the editor on the newer versions od Elementor PRO.
   You can assign this to me and I can take care of resolving this.

   🚀React with 🚀1Reacted by vytisbulkevicius
7. vytisbulkevicius

   assigned

   preda-bogdan

   on Apr 16, 2024
8. vytisbulkevicius

   added

   Priority-MediumExpected resolution time - up to 1 month.Expected resolution time - up to 1 month.

   on Apr 16, 2024
9. preda-bogdan

   added

   small(1-3h) This label is used for issues that can be completed within 3 hours or less.(1-3h) This label is used for issues that can be completed within 3 hours or less.

   on Apr 16, 2024
10. preda-bogdan

    added 2 commits that reference this issue on Apr 16, 2024

    fix: elementor pro issue in obfx Codeinwp/themeisle-companion#844

    3dbe12d

    chore: updated internal dependency #844

    27d01bb
11. preda-bogdan

    linked a pull request that will close this issueRelease #845on Apr 16, 2024
12. preda-bogdan commented on Apr 16, 2024

    

    preda-bogdan

    on Apr 16, 2024

    Contributor

    More actions

    I've patched the issue in the linked package, updated the dependency, and prepared a release.
    I've skipped the code review as the change was very small.
    cc: @vytisbulkevicius
    Do you want me to do a release?

    👍React with 👍1Reacted by vytisbulkevicius
13. vytisbulkevicius

    closed this as completedin #845on Apr 17, 2024