Add Python-interface for geometry constructor and geometry class - #3403

Merged

garth-wells merged 36 commits into

mainfrom

dokken/geometry-python-class

Sep 17, 2024

jorgensd commented Sep 15, 2024

Member

Continuation of #3400.

Add Geometry Python class and appropriate constructor (create_geometry).
Expose some bindings and wrap return types (Geometry and CoordinateElement) when returned from Python objects.

jorgensd added 5 commits

September 14, 2024 08:09


          Expose geometry constructor

bf5f190


          Accept 2D arrays for dofmap and points + simplify wrapper

11c26d5


          Revert weird linebreak

3dcb0e2


          Send in ((num_points, gdim) nodes and pad in nanobind

3189a14


          Add Python-interface for geometry constructor and geometry class with…

9c3a345

… documentation

jorgensd requested review from garth-wells and jhale

September 15, 2024 12:14

jorgensd added 2 commits

September 15, 2024 12:27


          Fix geometry access

d4fbe54


          Fix docstring

ae703dd

jorgensd added the documentation label

jorgensd added 5 commits

September 15, 2024 14:37


          Add python-interface of all of CoordinateElement.

480b1d5


          Doc fix

cbbc47e


          Ruff formatting

ed85a2f


          Fix class doc

80566c5


          Wrap geometry once

fb68e2c

jorgensd mentioned this pull request

Create topology Python wrapper #3406

Merged


          Fix geometry wrapper

7e3fffd

jhale requested changes

View reviewed changes

python/dolfinx/fem/element.py Outdated

python/dolfinx/fem/element.py Outdated

python/dolfinx/fem/element.py

python/dolfinx/mesh.py Outdated

python/dolfinx/mesh.py Outdated

python/dolfinx/mesh.py Outdated

python/dolfinx/mesh.py Outdated

python/dolfinx/fem/element.py Outdated

python/dolfinx/fem/element.py Outdated

python/dolfinx/fem/element.py Outdated

jorgensd commented

View reviewed changes

python/dolfinx/fem/element.py Outdated

jorgensd commented

View reviewed changes

python/dolfinx/fem/element.py Outdated

jorgensd commented

View reviewed changes

python/dolfinx/fem/element.py Outdated

jorgensd added 2 commits

September 16, 2024 16:55


          Apply suggestions from code review

63c1a9b


          Apply suggestions from code review

27ba12d

jorgensd commented

View reviewed changes

python/dolfinx/fem/element.py Outdated


          Apply suggestions from code review

07bc7a2

garth-wells reviewed

View reviewed changes

garth-wells left a comment

Member

Are the pull-back/push-forward functions for single cells only? If yes, this will often be slow. Would be good to support 'vectorisation' over multiple cells.

python/dolfinx/fem/element.py Outdated


          Modifying docstrings

ed7af81

jorgensd commented

View reviewed changes

python/dolfinx/mesh.py Outdated

jorgensd commented

View reviewed changes

python/dolfinx/mesh.py Outdated


          Apply suggestions from code review

04b8b5d

jorgensd commented

View reviewed changes

python/dolfinx/mesh.py Outdated

jorgensd commented

View reviewed changes

python/dolfinx/mesh.py Outdated


          Final set of full stops?

744d65c

jorgensd requested a review from jhale

September 16, 2024 15:10

jorgensd commented Sep 16, 2024 •

edited

Loading

Member Author

Are the pull-back/push-forward functions for single cells only? If yes, this will often be slow. Would be good to support 'vectorisation' over multiple cells.

This is introducing new functionality and a non-backwards compatible API and is best addressed in a separate PR

Base automatically changed from dokken/expose_geometry_constructor to main

September 16, 2024 16:15

jhale approved these changes

View reviewed changes


          Add type hints for push_forward/pull_back

b95069e

jorgensd commented Sep 16, 2024

Member Author

@garth-wells
I've made an issue describing potential actions that could be made in another PR, and some potential issues/interface changes one could make: #3408

jorgensd added 2 commits

September 16, 2024 18:11


          Merge branch 'main' into dokken/geometry-python-class

f84f6b5


          Use old typing to work on redhat

garth-wells requested changes

View reviewed changes

cpp/dolfinx/mesh/Geometry.h Outdated

python/dolfinx/fem/element.py Outdated

python/dolfinx/fem/element.py Outdated

python/dolfinx/fem/element.py Outdated

python/dolfinx/fem/element.py Outdated

python/dolfinx/mesh.py Outdated

python/dolfinx/mesh.py Outdated

python/dolfinx/mesh.py Outdated

python/dolfinx/mesh.py Outdated

python/dolfinx/mesh.py


          Merge branch 'main' into dokken/geometry-python-class

23e2c2f

garth-wells added the enhancement label

jorgensd and others added 5 commits

September 17, 2024 14:08


          Apply suggestions from @garth-wells

40931da

Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>


          Adhere to suggestions

d9c643e


          Add hsape

0b40346


          Merge branch 'main' into dokken/geometry-python-class

865ff45


          Ruff formatting

93b4bdb

jorgensd requested a review from garth-wells

September 17, 2024 12:24

jorgensd and others added 4 commits

September 17, 2024 12:39


          Fix indentation

c8de717


          Merge branch 'main' into dokken/geometry-python-class

d454536


          Merge branch 'main' into dokken/geometry-python-class

3ef1480


          Small doc updates

bf149f5

garth-wells approved these changes

View reviewed changes


          Doc formatting fix

91bb23e

garth-wells added this pull request to the merge queue

Merged via the queue into main with commit 873fac5

garth-wells deleted the dokken/geometry-python-class branch

September 17, 2024 19:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation enhancement