Skip to content

feat: added share button to community posts - #8317

Merged
FreeTubeBot merged 6 commits into
FreeTubeApp:developmentfrom
aditya0155:features/share-community-posts
Nov 22, 2025
Merged

feat: added share button to community posts#8317
FreeTubeBot merged 6 commits into
FreeTubeApp:developmentfrom
aditya0155:features/share-community-posts

Conversation

@aditya0155

@aditya0155 aditya0155 commented Nov 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Feature Implementation

Related issue

Description

  • This Pull Request introduces a "Share" button to the header of community posts, enabling users to easily copy links to specific posts. The feature is designed to blend seamlessly with the existing interface and supports generating links for both YouTube and Invidious.

Screenshots

share-community-post.mp4

Testing

Desktop

  • OS: Windows 11
  • OS Version: Windows 11 24H2 (OS Build 26100.7171)
  • FreeTube version: 0.23.12

Additional context

  • Tested all the features of this PR on multiple community posts, open link as well as Copy link is working as intended.

  • Also, let me know if anyone wants me to change the position of the share button

@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 20, 2025
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 20, 2025 01:52
@aditya0155 aditya0155 mentioned this pull request Nov 20, 2025
Closed
3 tasks
absidue
absidue reviewed Nov 20, 2025
View reviewed changes
Comment thread src/renderer/components/FtCommunityPost/FtCommunityPost.vue Outdated
Comment on lines +58 to +61
dropdown-position-y="bottom"
theme="base-no-default"
:use-shadow="false"
:size="16"

@absidue absidue Nov 20, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these theming changes so that the share button looks the same as it does everywhere else.

Comment thread src/renderer/components/FtCommunityPost/FtCommunityPost.vue Outdated
Comment on lines +351 to +357
<style scoped>
.header-share-button {
margin-left: auto;
align-self: center;
margin-right: 5px;
}
</style>

@absidue absidue Nov 20, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use separate files for CSS, see all other components in the project, this one also already has one, which is linked on the lime just above your changes. Please also fix the linting issues with your CSS that will appear once you move it to the correct location.

@absidue absidue added U: Waiting for Response from Author and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 20, 2025
auto-merge was automatically disabled November 20, 2025 12:28

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 20, 2025 12:29
auto-merge was automatically disabled November 20, 2025 12:31

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 20, 2025 12:31
@aditya0155

aditya0155 commented Nov 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@absidue Done I have updated the theming of share button to be same as other places and migrated the CSS code to its FtCommunityPost.scss

image

@absidue

absidue commented Nov 20, 2025

Copy link
Copy Markdown
Member

Please clean up the remaining theming code changes too (the extra properties and template changes), you only cleaned up one part...

@efb4f5ff-1298-471a-8973-3d47447115dc

efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 20, 2025

Copy link
Copy Markdown
Member

YT shows the placement of it next to the likes. I wondering if we should do the same?

@aditya0155

aditya0155 commented Nov 20, 2025

Copy link
Copy Markdown
Contributor Author

YT shows the placement of it next to the likes. I wondering if we should do the same?

image

auto-merge was automatically disabled November 21, 2025 01:07

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 21, 2025 01:07
@aditya0155
Refactor FtCommunityPost.scss styles
b13cd64 
Removed header share button styling and adjusted bottom section layout.
auto-merge was automatically disabled November 21, 2025 01:07

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 21, 2025 01:07
absidue
absidue reviewed Nov 21, 2025
View reviewed changes
Comment thread src/renderer/components/FtCommunityPost/FtCommunityPost.vue Outdated
Comment thread src/renderer/components/FtShareButton/FtShareButton.vue Outdated
Comment thread src/renderer/components/FtShareButton/FtShareButton.vue Outdated
@absidue absidue added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Nov 21, 2025
@FreeTubeBot
FreeTubeBot merged commit 4a5d8fa into FreeTubeApp:development Nov 22, 2025
5 checks passed
@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 22, 2025
@efb4f5ff-1298-471a-8973-3d47447115dc

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 26, 2026

Copy link
Copy Markdown
Member

Hi @aditya0155 i just noticed that Hide Sharing Actions under Settings -> Distraction Free doesnt hide this share button. Would you be able to make a change for this?

@aditya0155 aditya0155 mentioned this pull request Mar 27, 2026
Merged
1 task
@aditya0155

aditya0155 commented Mar 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

hey, @efb4f5ff-1298-471a-8973-3d47447115dc
I have opened #8891 for this fix.

Also, the share button styling doesn't quite match the other icons in the post footer. Would it be alright if I adjusted it for consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes
@absidue absidue absidue approved these changes
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes
@kommunarr kommunarr Awaiting requested review from kommunarr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Sharing actions to Community posts

5 participants

@aditya0155 @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @FreeTubeBot