Fix: publishedText is missing but the video isn't live or upcoming - #9321
Conversation
github-actions
Bot
added
the
PR: waiting for review
|
Most of the time when that message appears it is an actual issue that needs to be looked into, but I guess you'll just have to rely on noticing the parsing issues yourself. In this case with those unwatchable ads for a paid subscription service it is valid for the published date to be missing because they are not YouTube videos (the more correct solution would probably be to get rid of those ads like we do with members only videos, but for the moment I guess removing some genuinely useful logging will have to do). |
|
I haven't found a way to distinguish these videos (the ones without If you think it’s better to keep the error message because it’s more important to get an error when a viewable video has a parsing issue than to have no errors for a video that can’t be viewed, I understand, and this MR can be closed. |
|
@PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc Which would you prefer: Silent failure in situations where it is an actual problem or errors in situations where it isn't actually an error? |
|
It's probably fine to remove, for the rest of FreeTube we also go with "the users will inevitably complain when something breaks and even when it doesn't" approach, so using that here too is probably fine. |
|
If the error only appears in console, I guess it's fine to get a warning (instead of current error |
github-actions
Bot
removed
the
PR: waiting for review
* development: Fix: Hide 'Minimize to system tray' setting on Wayland (FreeTubeApp#9208) Translated using Weblate (Hungarian) Fix: import history from youtube adding trailing space to title (FreeTubeApp#9204) Fix keyboard shortcuts arent't working during "SABR backoff" (FreeTubeApp#9315) Fix incomplete watch progresss bar if video length has milliseconds (FreeTubeApp#9267) Translated using Weblate (Hungarian) Fix default quality not working when video aspect ratio is not 16/9 or 9/16 (FreeTubeApp#9312) Remove error when 'publishedText' is missing as it is a valid state (FreeTubeApp#9321) Fix LibRedirect download link in README (FreeTubeApp#9323) Bump actions/cache/restore from 5.0.5 to 6.0.0 (FreeTubeApp#9329) Bump actions/cache/save from 5.0.5 to 6.0.0 (FreeTubeApp#9330) Translated using Weblate (French) Fix premierDate parsing in subscription (FreeTubeApp#9309) # Conflicts: # src/renderer/components/GeneralSettings/GeneralSettings.vue
* development: (21 commits) Bump the webpack group across 1 directory with 2 updates (FreeTubeApp#9347) Bump the stylelint group across 1 directory with 3 updates (FreeTubeApp#9345) Bump vue from 3.5.38 to 3.5.39 (FreeTubeApp#9353) Bump js-yaml from 4.2.0 to 5.2.0 (FreeTubeApp#9348) Bump globals from 17.6.0 to 17.7.0 (FreeTubeApp#9350) Bump the fortawesome group with 5 updates (FreeTubeApp#9346) Bump shaka-player from 5.1.10 to 5.1.12 (FreeTubeApp#9351) Bump the eslint group with 6 updates (FreeTubeApp#9344) Translated using Weblate (Basque) Fix: Hide 'Minimize to system tray' setting on Wayland (FreeTubeApp#9208) Translated using Weblate (Hungarian) Fix: import history from youtube adding trailing space to title (FreeTubeApp#9204) Fix keyboard shortcuts arent't working during "SABR backoff" (FreeTubeApp#9315) Fix incomplete watch progresss bar if video length has milliseconds (FreeTubeApp#9267) Translated using Weblate (Hungarian) Fix default quality not working when video aspect ratio is not 16/9 or 9/16 (FreeTubeApp#9312) Remove error when 'publishedText' is missing as it is a valid state (FreeTubeApp#9321) Fix LibRedirect download link in README (FreeTubeApp#9323) Bump actions/cache/restore from 5.0.5 to 6.0.0 (FreeTubeApp#9329) Bump actions/cache/save from 5.0.5 to 6.0.0 (FreeTubeApp#9330) ... # Conflicts: # pnpm-lock.yaml
5 participants
Pull Request Type
Related issue
closes #8085
Description
It is a valid state to have an empty
publishedTextwhen the video is not live/premiere/upcoming.A good example is the paramountplus channel when using an IP located in USA:
YouTube:
FreeTube:
Differentiating valid and unvalid cases does not seem possible. It does not break FreeTube UI and does not impact the user when a video is returned without
publishedText, so I suggest to remove the log.Testing