Repository navigation
fix(docker): rewrite github ssh git deps to https for npm build - #1700
Merged
Merged
Conversation
Re-bin
approved these changes
Apr 4, 2026
Re-bin
left a comment
Re-bin
left a comment
Collaborator
There was a problem hiding this comment.
This change is now solid.
The original idea was right: make Docker builds stop depending on GitHub SSH access when npm install pulls git-based dependencies. But the first version only looked correct on the surface. It configured the same git config url.<base>.insteadOf key twice, which means one rewrite could overwrite the other and leave part of the failure mode unfixed.
I merged latest main and tightened the Dockerfile so both GitHub SSH URL forms are preserved as rewrite rules:
ssh://git@github.com/...git@github.com:...
That makes the fix match the actual issue report instead of only partially addressing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1699.