Repository navigation
refactor: unify agent runner lifecycle hooks - #2541
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentRunnerloopandsubagentonto the new interface while preserving existing behaviorWhy
AgentRunnerhad started to accumulate several ad-hoc callback entry points,which made the execution surface harder to extend and harder to read.
This change keeps the runner focused on the core execution loop and moves
lifecycle customization behind one small shared abstraction.
It also lays the groundwork for team mode, where team workers will need a
cleaner way to plug per-iteration behavior into the shared runner without
pushing team-specific logic down into the runner itself.
Test plan
pytest tests/agent/test_runner.py tests/agent/test_task_cancel.pypytest tests/cli/test_cli_input.py