Repository navigation
fix(channel.wecom): inbound mixed msg parse - #3161
Merged
Merged
Conversation
dzydzydzy7
changed the title
dzydzydzy7
changed the title
dzydzydzy7
changed the title
Collaborator
|
Nice PR! Could you add some unit tests to prevent regression? |
Contributor
Author
|
I added a unit test to |
Collaborator
see: https://github.com/HKUDS/nanobot/actions/runs/24444194871/job/71416713857?pr=3161 |
Contributor
Author
|
Unit tests already passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that wecom's mixed text and image messages are not being processed correctly by nanobot because the message structure is not parsed correctly.
See the wecom documentation for reference： https://developer.work.weixin.qq.com/document/path/100719#%E5%9B%BE%E6%96%87%E6%B7%B7%E6%8E%92%E6%B6%88%E6%81%AF
So I fixed that. And It works well on my mac book