Skip to content

fix: only advance dream_cursor on completed batches to prevent silent loss - #3631

Merged
Re-bin merged 1 commit into
HKUDS:mainfrom
JiajunBernoulli:fix-memory-cursor-advance
May 5, 2026
Merged

Re-bin merged 1 commit into
HKUDS:mainfrom
JiajunBernoulli:fix-memory-cursor-advance

Conversation

@JiajunBernoulli

@JiajunBernoulli JiajunBernoulli commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

Close #3630

@chengyongru chengyongru changed the title fix: only advance dream_cursor on completed batches to prevent silent… fix: only advance dream_cursor on completed batches to prevent silent loss May 5, 2026

@Re-bin Re-bin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Re-bin
Re-bin merged commit 9fa90b1 into HKUDS:main May 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dream advances .dream_cursor on Phase 1 errors, silently dropping memory entries (no Telegram surface, no /dream-log signal)

3 participants