Repository navigation
fix: resolve builtin skill reads - #4658
Merged
Merged
Conversation
hamb1y
marked this pull request as ready for review
July 2, 2026 17:52
chengyongru
added
priority: p2
Re-bin
approved these changes
Jul 6, 2026
Re-bin
left a comment
Re-bin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. This resolves bundled skill reads through a narrow fallback while keeping absolute paths and traversal blocked. The behavior is scoped, backward-compatible, and covered by tests. CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4655.
Summary
skills/<name>/...reads to bundled skills when the workspace path is missingskills/long-goal/SKILL.mdVerification