Repository navigation
feat(webui): support document attachments with ingress safeguards - #4771
Merged
Merged
Conversation
chengyongru
force-pushed
the
codex/webui-doc-attachments
branch
from
July 6, 2026 08:57
dc53e89 to
5098a99
Compare
chengyongru
force-pushed
the
codex/webui-doc-attachments
branch
from
July 7, 2026 01:45
5098a99 to
9206cf6
Compare
chengyongru
commented
Jul 7, 2026
This was referenced Jul 7, 2026
chengyongru
force-pushed
the
codex/webui-doc-attachments
branch
from
July 13, 2026 05:51
9206cf6 to
c20e0e7
Compare
chengyongru
marked this pull request as ready for review
July 14, 2026 03:22
chengyongru
force-pushed
the
codex/webui-doc-attachments
branch
from
July 14, 2026 03:58
e88cb0e to
455eb62
Compare
Collaborator
Author
okwillbe
pushed a commit
to okwillbe/nanobot
that referenced
this pull request
Aug 15, 2026
…UDS#4771) * feat: support document attachments in webui * fix(webui): normalize document attachment MIME * refactor(webui): move attachment policy out of channel * fix(webui): reject oversized attachments before send * fix(webui): align Portuguese attachment errors * refactor(webui): separate ingress and transport limits * fix(webui): reject malformed attachment payloads
StefanoParadisi
pushed a commit
to StefanoHernandez/nanobot
that referenced
this pull request
Oct 16, 2026
…UDS#4771) * feat: support document attachments in webui * fix(webui): normalize document attachment MIME * refactor(webui): move attachment policy out of channel * fix(webui): reject oversized attachments before send * fix(webui): align Portuguese attachment errors * refactor(webui): separate ingress and transport limits * fix(webui): reject malformed attachment payloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Supported documents
PDF, DOCX, XLSX, PPTX, TXT, Markdown, CSV, JSON, XML, HTML, YAML, TOML, LOG, INI, and CFG files are normalized to server-approved MIME types. SVG and unapproved archive/binary MIME types remain rejected.
Limits and transport behavior
Attachments are still sent as Base64 data URLs inside one WebSocket message. A lower configured
maxMessageBytescan therefore become the effective transport ceiling even when an attachment satisfies the 6 MiB business policy; the Composer now detects that condition while adding the file and reports it separately. Chunked or out-of-band upload is intentionally not part of this PR.Wire protocol change
Attachment validation errors now use
detail: "attachment_rejected"for both images and documents. The previousimage_rejecteddetail is intentionally not preserved as a compatibility alias; WebSocket clients that branch on this field must update to the new generic value. Stablereasonvalues continue to describe the rejection cause.Safety
Verification
ruff check, WebUI lint, and WebUI production build passed