Skip to content

fix(webui): sync package-lock.json to resolve docker build failure - #4863

Merged
Re-bin merged 1 commit into
HKUDS:mainfrom
SIDD-KIDD:fix-webui-package-lock
Jul 10, 2026
Merged

Re-bin merged 1 commit into
HKUDS:mainfrom
SIDD-KIDD:fix-webui-package-lock

Conversation

@SIDD-KIDD

@SIDD-KIDD SIDD-KIDD commented Jul 9, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR updates the webui/package-lock.json file to sync it with the current webui/package.json.

Why is this necessary?

Currently, building the Docker image from a fresh clone fails at the webui-builder stage (Step 5/23 : RUN npm ci).

Because npm ci requires absolute synchronization between package.json and the lockfile, the build crashes complaining about a missing dependency (diff@9.0.0) in the lockfile. It appears package.json was updated previously, but the newly generated lockfile was accidentally omitted. This PR restores that synchronization so the Docker build completes successfully.

**Error encountered during docker build -t nanobot .**:

Step 5/23 : RUN npm ci
npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm error
npm error Missing: diff@9.0.0 from lock file

Changes Made

  • Navigated to the webui/ directory and ran npm install to freshly resolve the dependency tree.
  • Committed the updated package-lock.json so that npm ci can execute successfully in the Dockerfile.

Testing

  • Verified docker build -t nanobot . completes successfully from scratch.
  • Verified no unintended package upgrades occurred outside of resolving the missing dependencies.

@chengyongru chengyongru added priority: p1 Important user-impacting issue or project priority with bounded impact or a reasonable workaround. bug Something isn't working fix webui CI/CD regression labels Jul 9, 2026

@Re-bin Re-bin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is the minimal lockfile repair for the already-declared diff dependency; it does not upgrade or alter unrelated packages.

A clean npm ci succeeds and the WebUI production build completes locally. GitHub Actions is also green across the full matrix.

@Re-bin
Re-bin merged commit e284592 into HKUDS:main Jul 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI/CD fix priority: p1 Important user-impacting issue or project priority with bounded impact or a reasonable workaround. regression valid webui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants