Repository navigation
fix(discord): route unauthorized DMs to pairing - #4899
Merged
Merged
Conversation
chengyongru
added
priority: p1
Collaborator
Author
|
Re-bin
approved these changes
Jul 13, 2026
Re-bin
left a comment
Re-bin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. This restores first-contact Discord DM pairing while keeping unauthorized guild messages rejected before channel-side effects. The adapter-local regression test covers the broken path, and the channel tests and CI are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseChannelpairing flowRoot cause
DiscordChannel._should_accept_inboundrejected every sender who was not already allowlisted or paired. That prevented the initial DM from reachingBaseChannel._handle_message, where pairing codes are generated.Tests
python -m pytest tests/channels/test_base_channel.py tests/channels/test_discord_channel.py -q(63 passed)python -m ruff check nanobot/channels/discord.py tests/channels/test_discord_channel.pyFixes #4897