Repository navigation
fix(gateway): harden health endpoint exposure - #4906
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security assessment
The gateway health listener already defaults to
127.0.0.1. Existing users may still have0.0.0.0in older or manually edited configs, and container deployments intentionally bind all interfaces inside the container. The endpoint returns only{"status": "ok"}and cannot invoke the agent, but an exposed listener still adds connection, bandwidth, and slow-client denial-of-service surface.This keeps explicit non-loopback deployments backward compatible while making the exposure visible and limiting application-level resource use.
Validation
PYTHONPATH="$PWD" pytest tests/cli/test_commands.py -q(117 passed)PYTHONPATH="$PWD" ruff check nanobot/cli/commands.py tests/cli/test_commands.pygit diff --checkdocker compose config