Repository navigation
fix(cron): coerce null runHistory ms fields from jobs.json - #4985
Merged
Merged
Conversation
Explicit JSON null for runAtMs/durationMs bypassed the missing-key default and raised TypeError on load. Treat null/blank like missing.
Same present-null footgun as runHistory; route all required store ints through _store_int.
chengyongru
added
priority: p1
This was referenced Jul 19, 2026
Re-bin
approved these changes
Jul 21, 2026
Re-bin
left a comment
Re-bin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. This fixes the persisted cron compatibility bug at the deserialization boundary without changing scheduling behavior.
The current head is green, merges cleanly with the latest main, and the focused cron regression suite passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jobs.json can store runAtMs/durationMs (and createdAtMs/updatedAtMs) as explicit JSON null. get_camel_snake returns that null, so bare int() raised TypeError and quarantined the store. Treat null/blank like a missing key (0), same idea as the dual-case and string-ms load hardening.
Repro: put
"runAtMs": nullin a runHistory row, then load jobs.