Skip to content

[Fix] Check if game install folder exists before anything else - #5317

Merged
arielj merged 3 commits into
mainfrom
no-prefix-for-not-available-games
Mar 13, 2026
Merged

arielj merged 3 commits into
mainfrom
no-prefix-for-not-available-games

Conversation

@arielj

@arielj arielj commented Feb 15, 2026 •

Copy link
Copy Markdown
Collaborator

Currently, we only check if the game is not available and ask the user if they want to remove it after it failed trying to actually run the game and only if we detect specific error messages.

This created many problems:

  • it was doing things like creating a wine prefix first to then fail, so if a user removed the game in that prompt there was a useless prefix left
  • it only worked if the error had the appears to be deleted substring, making it kinda brittle
  • I understand it was not properly working for amazon games (I've seen many reports about not being able to remove games, but I don't have an account there to test it) because it didn't have that substring

Now, when we want to launch a game, the very first thing we check is if its install folder exists, if it does not we prompt the user if they want to remove the game or not and we don't do anything else.

Closes #3097


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj
arielj requested review from a team, BananaWorks07, CommandMC and flavioislima and removed request for a team February 15, 2026 15:53
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 15, 2026
@flavioislima flavioislima modified the milestones: 2.20, 2.21 Feb 20, 2026
@arielj
arielj force-pushed the no-prefix-for-not-available-games branch from a86f9ec to d0c12de Compare March 10, 2026 00:41

@flavioislima flavioislima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arielj
arielj merged commit 81fd5d0 into main Mar 13, 2026
8 of 9 checks passed
@arielj
arielj deleted the no-prefix-for-not-available-games branch March 13, 2026 23:01
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When a game is not available, trying to execute it updates the prefix before warnings that it's not available

2 participants