Skip to content

Fix #4699: Read no more than the last 1 MB of log files to be shown - #5457

Merged
arielj merged 9 commits into
Heroic-Games-Launcher:mainfrom
thatguywiththekids:dont-crash-on-large-logs
Sep 6, 2026
Merged

arielj merged 9 commits into
Heroic-Games-Launcher:mainfrom
thatguywiththekids:dont-crash-on-large-logs

Conversation

@thatguywiththekids

@thatguywiththekids thatguywiththekids commented Apr 3, 2026 •

Copy link
Copy Markdown
Contributor

Fix #4699 by only reading the last 1 MB of log files.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary) (no affected docs that I know of)

@flavioislima

flavioislima commented Apr 3, 2026 •

Copy link
Copy Markdown
Member

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@thatguywiththekids

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@thatguywiththekids thatguywiththekids changed the title Fix #4699 Fix #4699: read no more than the last 1 MB of log files to be shown Apr 3, 2026
@thatguywiththekids thatguywiththekids changed the title Fix #4699: read no more than the last 1 MB of log files to be shown Fix #4699: Read no more than the last 1 MB of log files to be shown Apr 3, 2026
@flavioislima
flavioislima requested review from a team, BananaWorks07, CommandMC, arielj, biliesilva, flavioislima and imLinguin and removed request for a team April 6, 2026 19:02
@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 6, 2026
Comment thread src/backend/utils/filesystem/read_last_bytes.ts Outdated
Comment thread src/backend/utils/filesystem/read_last_bytes.ts Outdated
Comment thread src/frontend/screens/Settings/sections/LogSettings/index.tsx Outdated
@thatguywiththekids
thatguywiththekids force-pushed the dont-crash-on-large-logs branch from 720fe07 to 3257a95 Compare April 17, 2026 22:38
@thatguywiththekids

thatguywiththekids commented Apr 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Reviews by @CommandMC and @arielj have been acted upon.

@thatguywiththekids

Copy link
Copy Markdown
Contributor Author

Are the reviewers OK with the changes now?

@imLinguin
imLinguin requested review from CommandMC and arielj April 25, 2026 00:28
Comment thread src/backend/utils/strings.ts
@thatguywiththekids

Copy link
Copy Markdown
Contributor Author

This has been approved for about 2 weeks. Is anything missing?

@CommandMC

Copy link
Copy Markdown
Member

For most PRs (especially from new contributors), we require approval from two team members before merging. So someone other than myself would also have to review & approve
You've done a great job following the established structure of the codebase though, so I'd assume that as soon as someone else has time to look at your changes, an approval would be easy to give

@arielj arielj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@arielj
arielj merged commit 5089bdb into Heroic-Games-Launcher:main Sep 6, 2026
10 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Sep 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When a game log is too big, opening the Logs modal can crash Heroic

4 participants