Repository navigation
fix: close user-menu items on click, wait for jQuery before init - #20
Merged
Merged
Conversation
Injected menu items aren't real MenuItems, so clicking one left the MUI popover open behind whatever it navigated to; now clicks the popover's backdrop to close it, same as a real outside click. jQuery is exposed globally by jellyfin-web but not always by the time this deferred script runs, causing "$ is not defined" and silently killing the script before it ever attached its MutationObserver (confirmed via Android device logcat). Now waits for it. Also version-busts the injected script's URL so client caches actually pick up updates.
IAmParadox27
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Injected menu items aren't real MenuItems, so clicking one left the MUI popover open behind whatever it navigated to; now clicks the popover's backdrop to close it, same as a real outside click.
jQuery is exposed globally by jellyfin-web but not always by the time this deferred script runs, causing "$ is not defined" and silently killing the script before it ever attached its MutationObserver (confirmed via Android device logcat). Now waits for it.
Also version-busts the injected script's URL so client caches actually pick up updates.
Fixes #19