Skip to content

MelBands algorithm updates - #849

Merged
dbogdanov merged 8 commits into
masterfrom
melfixes
Jul 15, 2019
Merged

dbogdanov merged 8 commits into
masterfrom
melfixes

Conversation

@dbogdanov

Copy link
Copy Markdown
Member
  • Implement correct slaneyMel mel scale conversion formula
  • use 'htkMel' scale by default
  • Update unit tests, add regression tests

Previously, the 'slaneyMel' scale was introduced in 9dff282, where
it was erroneously computed using the HTK Mel scale re-using our
previous code for Mel scale computation in MelBands.

Use a new correct function from essentiamath.h to compute Mel
scale conversion following Slaney's formula.

Set htkMel as the default scale to ensure backwards compatibility
with all previous versions of the MelBands algorithm.
- Fix failing testWrongInputSize test
- Add flat spectrum tests for both htkMel and slaneyMel
- Add regression tests for htkMel and slaneyMel
Merge Travis deploy updates for PRs
Add 'unit_tri' triangle area normalizations by the estimated band
bandwidth for compatibility with Mel bands implementation in Librosa
These tests ensure compatibility with Librosa
Following the same update in MelBands (112de48).
@dbogdanov
dbogdanov merged commit 84b9625 into master Jul 15, 2019
@dbogdanov
dbogdanov deleted the melfixes branch July 24, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant