Repository navigation
Let plugins receive raw touch input and multi-finger taps on UI nodes - #1004
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by the maintainer (no issue).
Summary
UI nodes can now declare pointer-down, pointer-move, pointer-up and tap to receive raw per-finger positions every 16 ms and multi-finger taps, so plugins can build a touchpad. A pointer-move still waiting for a slow plugin is replaced by the newer one in the host and the plugin runtime instead of queuing without bound.
Testing
Full Release build and test suites pass, plus runtime, web client and legacy touch shim specs. Verified end to end with a scratch plugin on a disposable host, driven from Chrome and a real tablet over the LAN, including moving and clicking the macOS cursor from the widget.
Plugin SDK / API compatibility
Added UiComponentEvents.PointerDown, PointerMove, PointerUp and Tap, three UiComponentModifiers constants, the UiPointerSample, UiPointerDown and UiPointerUp structs, and four readers on UiEventData.
[Obsolete]and[MacroDeckDeprecated], is in the deprecation registry, and still worksNotes
A plugin that already declared its own event named tap or pointer-* now claims the pointer on its tile, the same as when drag was added. The Companion App needs a matching change.
Checklist