Repository navigation
Fix links not opening from the Linux AppImage on KDE Plasma 6 - #1051
Merged
Merged
Conversation
manuelmayer-dev
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1034
Summary
In the Linux AppImage, links and the Open website, Open file, Open folder and data directory actions did nothing on KDE Plasma 6, because the bundled xdg-open ran instead of the system one. They now go to the system opener with the AppImage's own paths removed from its environment.
Testing
Full solution build and tests, cargo test, fmt and clippy pass; new Rust and C# tests cover the environment rules, and the Linux-only tests pass in a Linux container. In an Arch container, the shipped beta.14 AppImage launcher chain with the new code now reaches the system xdg-open and kde-open, where before nothing was called. Not tested on a real Plasma 6 desktop.
Notes
Launched applications, Run command and plugin processes keep the inherited environment, since the host and plugins may rely on the bundled ICU. A relative Open file path still takes the old route.
Checklist