Repository navigation
Add a Twitch chat widget and withdraw widgets of disabled integrations - #1057
Merged
Merged
Conversation
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Twitch Chat widget, offered while a Twitch account is set up, with emotes, emoji, badges and name colours, and batches incoming messages so busy chats stay cheap. Disabling an integration now also withdraws its widget types, layouts, folder views and screensavers and keeps its devices offline, including plugins that reconnect while disabled.
Testing
Release build with warnings as errors and all .NET, runtime, web client and desktop-ui suites pass, except Plugin.Cli A_project_is_actually_built_before_its_output_is_resolved, which fails locally with dotnet build exit 155 in its temporary project. Verified with a scratch plugin in a disposable host and with a live Twitch chat in the desktop UI.
Plugin SDK / API compatibility
UI model additions: spans on ui.text, overflow clip-start on ui.stack (component version 2 with a fallback). Behaviour change: while the user has an integration turned off, its registrations are validated but not kept and its devices stay offline, listed under behaviour changes that moved no version.
Checklist